Date: Thu, 16 May 2013 20:37:34 -0500 From: Jeremy Messenger <mezz.freebsd@gmail.com> To: Pedro Giffuni <giffunip@tutopia.com> Cc: FreeBSD GNOME Users <gnome@freebsd.org> Subject: Re: ports/178552: Update print/freetype2 to version 2.4.12 Message-ID: <CADLFttcjUthVAPhOgWyYk2tjMZ_buRD%2ByTmKCbV-QD6eGu9aQw@mail.gmail.com> In-Reply-To: <51952FA5.5010307@tutopia.com> References: <201305150530.r4F5UDxN042667@freefall.freebsd.org> <CADLFtteQMAOK8rOnCidUFUwVoo_WNJvCOHf=Q0MrKgJtZM-LHA@mail.gmail.com> <72f5fb9e17f4fcd3153990f255752633@tutopia.com> <CADLFttf6zwH8UsOoSd71YPqgZEMQj3Xu-mZYECvnxojjFX=bAA@mail.gmail.com> <51952FA5.5010307@tutopia.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 16, 2013 at 2:12 PM, Pedro Giffuni <giffunip@tutopia.com> wrote: > On 15.05.2013 13:42, Jeremy Messenger wrote: >> >> On Wed, May 15, 2013 at 11:38 AM, <giffunip@tutopia.com> wrote: >>> >>> On Wed, 15 May 2013 07:51:50 -0500, Jeremy Messenger >>> <mezz.freebsd@gmail.com> wrote: >>>>> >>>>> Apart from some minor issues, this version of FreeType supports the >>>>> new CFF engine donated by Adobe in collaboration with Google. >>>>> >>>>> Testing of this new feature is encouraged but in order to activate >>>>> it the code must be patched so I added the suggested patch that sets >>>>> it as the new default hinter. >>>> >>>> <snip> >>>> >>>> Why did you enable it by default? This is a testing feature and they >>>> must have disable it for some reasons too, so it needs to be disabled >>>> by default with the optional provide. It will be enable by default >>>> when they enable it. We need to follow its tarball's default. >>>> >>> It is simply a very desirable feature, specially if you have >>> Opentype fonts available. >>> >>> They will be enabling it by default on their next release but >>> it is already considered stable enough (it just works here). >> >> The freetype2 is not a port that where you can just throw it quick. >> They didn't enable this now, because it's not ready so the ports tree >> isn't ready for this either. > > > I understand they made this release specifically so people > would give it more testing. > > I just couldn't wait and I enabled it :). > > >>> I think we should at least have an option to enable it. >> >> Yes, it's what I have suggested in my first replied. ;-) > > > Hmm.. the extra patch solved the issue for me but it was > indeed a quick fix. I personally feel little motivation to do > more if it doesn't reflect in the final package though. > > What about adding an option but enabling it by default? ;). > Otherwise I guess we can just close the PR and wait for a > new version. It really does need to be disabled by default. Next time when you create a patch. Please don't use ":" in the name of file. The ports tree doesn't allow it anymore (years ago) only if you add a new file. It needs to be "_" as I believe that it's in the porter handbook. > Pedro. -- mezz.freebsd@gmail.com - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLFttcjUthVAPhOgWyYk2tjMZ_buRD%2ByTmKCbV-QD6eGu9aQw>