Date: Tue, 16 Mar 2004 16:50:23 -0500 From: John Baldwin <jhb@FreeBSD.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: peter@wemm.org Subject: Re: cvs commit: src/sys/i386/include dvcfg.h physio_proc.h src/sys/amd64/include dvcfg.h physio_proc.h src/sys/compat/netbsd dvcfg.h physio_proc.h src/sys/dev/ct bshw_machdep.c ct.c ct_isa.c src/sys/d Message-ID: <200403161650.23938.jhb@FreeBSD.org> In-Reply-To: <20040317.045645.83723898.imp@bsdimp.com> References: <20040316.224458.21308983.non@ever.sanda.gr.jp> <20040316125222.G96418@root.org> <20040317.045645.83723898.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 16 March 2004 03:56 pm, M. Warner Losh wrote: > In message: <20040316125222.G96418@root.org> > > Nate Lawson <nate@root.org> writes: > : On Tue, 16 Mar 2004, M. Warner Losh wrote: > : > In message: <20040316.224458.21308983.non@ever.sanda.gr.jp> > : > > : > non@ever.sanda.gr.jp writes: > : > : From: Takahashi Yoshihiro <nyan@jp.FreeBSD.org> > : > : Date: Tue, 16 Mar 2004 21:14:53 +0900 (JST) > : > : > : > : > In article <200403150741.38591.peter@wemm.org> > : > : > > : > : > Peter Wemm <peter@wemm.org> writes: > : > : > > I don't really care where they go, as long as it isn't in the MD > : > : > > include areas (they are not MD!), and not in sys/. My favorites > : > : > > right now are dev/pc98/* or compat/pc98/*. I would also like > : > : > > sys/device_port.h to move there too since it is used by the same > : > : > > group of ct/ncv/nsp/stg drivers. > : > : > > : > : > I repeat that they have NO relations with pc98. So, the above > : > : > proposals are not acceptable. > : > : > : > : I agree with nyan-san. They are not specific to pc98 not for > : > : compatibility. I think they should be in sys/ or dev/dev/* or > : > : somewhere MI and not in compat/* . > : > > : > dev/pc98 isn't right. I have pcmcia cards that are supported by the > : > ncv, nsp and stg drivers running on an i386 box. dev/sys is fine by > : > me too if you are looking for a name. > : > : Blech, did you see the suggestion for /src/sys/dev/ic/ ? > > Yes. I saw that since I made it. > > I like dev/include, but maybe a more fundamental question is that > these are a portability layer shared between a number of differen > systems, does that layer have a name? Does it even need to exist? dvcfg seems to provide an array of softc's, something we tried to kill in new-bus. physio_proc() doesn't do anything at all. Is there a reason we use these APIs rather than just chucking the physio_proc() one and replacing dvcfg() with sane use of device_get_softc() and dev->si_drv1 instead? -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200403161650.23938.jhb>