Date: Wed, 31 Jan 2024 13:57:41 -0700 From: Warner Losh <imp@bsdimp.com> To: Ed Maste <emaste@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: ed3563b0ac31 - main - csu: add crtbrand.o dependency on sys/param.h Message-ID: <CANCZdfqCWMd_tzRwHR4=kQHmuVZPyvdvEW6ZRWUVqbN4VC%2BY2Q@mail.gmail.com> In-Reply-To: <202401312041.40VKfgE0080600@gitrepo.freebsd.org> References: <202401312041.40VKfgE0080600@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Jan 31, 2024, 1:41 PM Ed Maste <emaste@freebsd.org> wrote: > The branch main has been updated by emaste: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=ed3563b0ac31d854bf907d4d847ac0195ec9637b > > commit ed3563b0ac31d854bf907d4d847ac0195ec9637b > Author: Ed Maste <emaste@FreeBSD.org> > AuthorDate: 2024-01-12 15:01:49 +0000 > Commit: Ed Maste <emaste@FreeBSD.org> > CommitDate: 2024-01-31 20:40:27 +0000 > > csu: add crtbrand.o dependency on sys/param.h > > __FreeBSD_version is recorded in *crt1.o and crti.o via crtbrand.o. > Add > an explicit dependency to pick up __FreeBSD_version bumps. > > Additional changes are required to fully plumb *crt1.o dependencies > through the build. > So a kernel bump now rebuilds (or at least relinks) everything? Or soon will? Reported by: bapt > Reviewed by: bapt > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D43417 > --- > lib/csu/Makefile.inc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/csu/Makefile.inc b/lib/csu/Makefile.inc > index 55aaf589f48f..1509a1ece2c3 100644 > --- a/lib/csu/Makefile.inc > +++ b/lib/csu/Makefile.inc > @@ -55,6 +55,9 @@ Scrt1_c.o: ${CRT1SRC} > Scrt1.o: Scrt1_c.o ${CRT1OBJS} ${CRT1OBJ} > ${LD} ${_LDFLAGS} -o ${.TARGET} -r ${.ALLSRC:M*.o} > > +# __FreeBSD_version is recorded in crt1.o et al via crtbrand. > +crtbrand.o: ${SRCTOP}/sys/sys/param.h > + > crtbegin.o: crtbegin.c > crtbeginS.o: crtbegin.c > crtbeginT.o: crtbegin.c > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jan 31, 2024, 1:41 PM Ed Maste <<a href="mailto:emaste@freebsd.org">emaste@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The branch main has been updated by emaste:<br> <br> URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=ed3563b0ac31d854bf907d4d847ac0195ec9637b" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=ed3563b0ac31d854bf907d4d847ac0195ec9637b</a><br>; <br> commit ed3563b0ac31d854bf907d4d847ac0195ec9637b<br> Author: Ed Maste <emaste@FreeBSD.org><br> AuthorDate: 2024-01-12 15:01:49 +0000<br> Commit: Ed Maste <emaste@FreeBSD.org><br> CommitDate: 2024-01-31 20:40:27 +0000<br> <br> csu: add crtbrand.o dependency on sys/param.h<br> <br> __FreeBSD_version is recorded in *crt1.o and crti.o via crtbrand.o. Add<br> an explicit dependency to pick up __FreeBSD_version bumps.<br> <br> Additional changes are required to fully plumb *crt1.o dependencies<br> through the build.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">So a kernel bump now rebuilds (or at least relinks) everything? Or soon will? </div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Reported by: bapt<br> Reviewed by: bapt<br> Sponsored by: The FreeBSD Foundation<br> Differential Revision: <a href="https://reviews.freebsd.org/D43417" rel="noreferrer noreferrer" target="_blank">https://reviews.freebsd.org/D43417</a><br>; ---<br> lib/csu/Makefile.inc | 3 +++<br> 1 file changed, 3 insertions(+)<br> <br> diff --git a/lib/csu/Makefile.inc b/lib/csu/Makefile.inc<br> index 55aaf589f48f..1509a1ece2c3 100644<br> --- a/lib/csu/Makefile.inc<br> +++ b/lib/csu/Makefile.inc<br> @@ -55,6 +55,9 @@ Scrt1_c.o: ${CRT1SRC}<br> Scrt1.o: Scrt1_c.o ${CRT1OBJS} ${CRT1OBJ}<br> ${LD} ${_LDFLAGS} -o ${.TARGET} -r ${.ALLSRC:M*.o}<br> <br> +# __FreeBSD_version is recorded in crt1.o et al via crtbrand.<br> +crtbrand.o: ${SRCTOP}/sys/sys/param.h<br> +<br> crtbegin.o: crtbegin.c<br> crtbeginS.o: crtbegin.c<br> crtbeginT.o: crtbegin.c<br> </blockquote></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqCWMd_tzRwHR4=kQHmuVZPyvdvEW6ZRWUVqbN4VC%2BY2Q>