Date: Thu, 23 Jan 2020 08:22:55 -1000 (HST) From: Jeff Roberson <jroberson@jroberson.net> To: Mark Johnston <markj@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r357055 - head/sys/sparc64/sparc64 Message-ID: <alpine.BSF.2.21.9999.2001230822130.1198@desktop> In-Reply-To: <202001231718.00NHIwq7004333@repo.freebsd.org> References: <202001231718.00NHIwq7004333@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 23 Jan 2020, Mark Johnston wrote: > Author: markj > Date: Thu Jan 23 17:18:58 2020 > New Revision: 357055 > URL: https://svnweb.freebsd.org/changeset/base/357055 > > Log: > sparc64: Busy the TSB page before freeing it in pmap_release(). > > This is now required by vm_page_free(). > > PR: 243534 > Reported and tested by: Michael Reim <kraileth@elderlinux.org> > > Modified: > head/sys/sparc64/sparc64/pmap.c > > Modified: head/sys/sparc64/sparc64/pmap.c > ============================================================================== > --- head/sys/sparc64/sparc64/pmap.c Thu Jan 23 17:08:33 2020 (r357054) > +++ head/sys/sparc64/sparc64/pmap.c Thu Jan 23 17:18:58 2020 (r357055) > @@ -1302,6 +1302,7 @@ pmap_release(pmap_t pm) > m = TAILQ_FIRST(&obj->memq); > m->md.pmap = NULL; > vm_page_unwire_noq(m); > + vm_page_xbusy(m); vm_page_xbusy() is unsafe long-term and I will be removing it as soon as I get patches into drm. It technically 'works' now but not for great reasons. Thanks, Jeff > vm_page_free_zero(m); > } > VM_OBJECT_WUNLOCK(obj); >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.21.9999.2001230822130.1198>