Date: Sun, 03 Jul 2005 00:47:55 -0000 From: "Daniel O'Connor" <doconnor@gsoft.com.au> To: freebsd-current@freebsd.org, John-Mark Gurney <gurney_j@resnet.uoregon.edu> Cc: peadar@freebsd.org, Peter Edwards <peadar.edwards@gmail.com>, FreeBSD current mailing list <current@freebsd.org>, freebsd-amd64@freebsd.org Subject: Re: if_sk patch to get more info from people with problems Message-ID: <200411031304.31518.doconnor@gsoft.com.au> In-Reply-To: <20041102190851.GR22681@funkthat.com> References: <Pine.BSF.4.53.0411011123190.90940@e0-0.zab2.int.zabbadoz.net> <34cb7c8404110209563fc01498@mail.gmail.com> <20041102190851.GR22681@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart6075508.at3aiTZfpd Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wed, 3 Nov 2004 05:38, John-Mark Gurney wrote: > Peter Edwards wrote this message on Tue, Nov 02, 2004 at 17:56 +0000: > > A (very) quick look at the source reveals that buffers are allocated > > via sk_rxeof()->sk_newbuf()->sk_jalloc() in the interrupt receive > > function, with the softc lock held in sk_rxeof(). > > > > They're freed by the mbuf system via a call to sk_jfree(), but that > > doesn't hold the SK_LOCK. Is this possibly the source of the > > corruption problems? What am I missing? > > This compiles, anyway :-) > > Well, try the attached patch (it also includes my changes from a previous > diff) that will see what happens... Make sure you have your kernel > compiled with WITNESS and INVARIANTS... If you hit one of these > asserts, make sure you post the back trace... I didn't see the previous patch, but I applied it from this one to 4.x and = it=20 seems to be behaving itself now. I'll keep testing it, but previously it would lock up pretty quickly :) =2D-=20 Daniel O'Connor software and network engineer for Genesis Software - http://www.gsoft.com.au "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C --nextPart6075508.at3aiTZfpd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBiEO35ZPcIHs/zowRAqmIAJ9ukCzqgBKkmsJPztDSTdueJAdTjQCgjjH4 o92QPeHXyjlvAKPIjKEbhQU= =3lPf -----END PGP SIGNATURE----- --nextPart6075508.at3aiTZfpd--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200411031304.31518.doconnor>