Date: Mon, 6 Mar 2017 20:04:19 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Hiren Panchasara <hiren@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Gleb Smirnoff <glebius@freebsd.org> Subject: Re: svn commit: r314813 - head/sys/kern Message-ID: <2CEAC560-E2D2-4790-9006-FEED1BFF5A78@gmail.com> In-Reply-To: <9747B513-8D23-487D-8FF9-721265C1CF44@gmail.com> References: <201703070020.v270K2vA039655@repo.freebsd.org> <9747B513-8D23-487D-8FF9-721265C1CF44@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Mar 6, 2017, at 19:08, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: … > The KASSERT is bad — please fix it. From https://ci.freebsd.org/job/FreeBSD-head-amd64-test/1994/console : > > add host 127.0.0.1panic: sbcut_internal: len is 0 but it is supposed to be +ve len == 0 has special meaning; please see sbflush_internal. This works. Thanks, -Ngie $ svn diff sys/kern/uipc_sockbuf.c Index: sys/kern/uipc_sockbuf.c =================================================================== --- sys/kern/uipc_sockbuf.c (revision 314827) +++ sys/kern/uipc_sockbuf.c (working copy) @@ -1043,8 +1043,7 @@ { struct mbuf *m, *next, *mfree; - KASSERT(len > 0, ("%s: len is %d but it is supposed to be +ve", - __func__, len)); + KASSERT(len >= 0, ("%s: len is negative (%d)", __func__, len)); KASSERT(len <= sb->sb_ccc, ("%s: len: %d is > ccc: %u", __func__, len, sb->sb_ccc)); [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYvjFDAAoJEPWDqSZpMIYV2C4P/R/mEhZeNSeOXOfoYeb71RmI YbnBfeS+aoojK5KswcgEmsGHcTBBDAuncNhAysz19h/BX98X14dBRq9qw7YjGZml b0SlaBSciVCPgIoDXmOPks3btbnxDOUdzSRYPe2RPW4uQtD+YYDjpSmpvOk0Ukyx MdhHHc9QNxJ+Pl47QF6nI/835/w/SU5Muhv2UQ8zTabQCymk6NPnU78MoDWc1mJH tJqEQldpPCMt6tbyhqDuZTq0WapMueBjGox+ZarS5+WSq9YZEwmIASFsK6av33pG kC96mzEQdljt76ffMpqx6Hx/1+e9HDU7w9hJ4irlcZRH0+t2AunKfkpX9TfbCJ2l cxLCvg9TIhYSg73S0slpMFK+6zrqDCPxihkmShaU8HrinPlDhWIApyyhEiS5b0wn F2zEK6AjoRagyIl15GJSZy+SpV6Bcr1civDfQ853kB2PMnP+nhgpFc2ODb5vgMpM K+wtQVb1/sxQj3w9sriukpfVlriEdYKH5goQGXK/DsTqXsbmILAMIyYjWOoLEJn/ YsS35SYVo53QwdyYvgss3Qh3BflNJidmYW1xQHBIeuM5u+r6S+HdK+hDtq6ccpHV z0TzPLUbhgqbBMeKyBitJjbpU/cu0NDonARQyHsnjZiBQKe9+8/psUNN678+gl0k fP7L35mZ10ftWiZIlTQN =JFcS -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2CEAC560-E2D2-4790-9006-FEED1BFF5A78>