Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Jun 2021 17:28:55 +0200
From:      Emmanuel Vadot <manu@bidouilliste.com>
To:        Neel Chauhan <nc@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: b47f461c8e67 - main - linuxkpi: Add list_for_each_entry_lockless() macro
Message-ID:  <20210610172855.287c62fd10d7963e2364e342@bidouilliste.com>
In-Reply-To: <202106101515.15AFFfsJ091223@gitrepo.freebsd.org>
References:  <202106101515.15AFFfsJ091223@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 10 Jun 2021 15:15:41 GMT
Neel Chauhan <nc@FreeBSD.org> wrote:

> The branch main has been updated by nc (ports committer):
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=b47f461c8e67253fdb394968428b760e880baa08
> 
> commit b47f461c8e67253fdb394968428b760e880baa08
> Author:     Neel Chauhan <nc@FreeBSD.org>
> AuthorDate: 2021-06-10 15:14:20 +0000
> Commit:     Neel Chauhan <nc@FreeBSD.org>
> CommitDate: 2021-06-10 15:15:29 +0000
> 
>     linuxkpi: Add list_for_each_entry_lockless() macro
>     
>     This is needed by the drm-kmod 5.7 update.

 You did not explain why it's the same as list_for_each_entry.

>     Approved by:            hselasky (src)
>     MFC after:              3 days
>     Differential Revision:  https://reviews.freebsd.org/D30708
> ---
>  sys/compat/linuxkpi/common/include/linux/list.h | 2 ++
>  sys/sys/param.h                                 | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sys/compat/linuxkpi/common/include/linux/list.h b/sys/compat/linuxkpi/common/include/linux/list.h
> index 37b5b751d21b..93db449a4473 100644
> --- a/sys/compat/linuxkpi/common/include/linux/list.h
> +++ b/sys/compat/linuxkpi/common/include/linux/list.h
> @@ -202,6 +202,8 @@ list_del_init(struct list_head *entry)
>  	for (p = list_entry((h)->next, typeof(*p), field); &(p)->field != (h); \
>  	    p = list_entry((p)->field.next, typeof(*p), field))
>  
> +#define list_for_each_entry_lockless(...) list_for_each_entry(__VA_ARGS__)
> +
>  #define list_for_each_entry_safe(p, n, h, field)			\
>  	for (p = list_entry((h)->next, typeof(*p), field),		\
>  	    n = list_entry((p)->field.next, typeof(*p), field); &(p)->field != (h);\
> diff --git a/sys/sys/param.h b/sys/sys/param.h
> index d78612b5ebb9..afcba3990b07 100644
> --- a/sys/sys/param.h
> +++ b/sys/sys/param.h
> @@ -76,7 +76,7 @@
>   * cannot include sys/param.h and should only be updated here.
>   */
>  #undef __FreeBSD_version
> -#define __FreeBSD_version 1400020
> +#define __FreeBSD_version 1400021

 No need to bump FreeBSD_version with each one of your commit to
linuxkpi, this will only be painful for people tracking current and
building there packages.

>  /*
>   * __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD,


-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210610172855.287c62fd10d7963e2364e342>