Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 15 Jul 2018 21:10:20 +0000 (UTC)
From:      Alan Somers <asomers@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r336319 - head/sys/security/audit
Message-ID:  <201807152110.w6FLAKhR001741@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: asomers
Date: Sun Jul 15 21:10:19 2018
New Revision: 336319
URL: https://svnweb.freebsd.org/changeset/base/336319

Log:
  auditon(2): fix A_SETPOLICY with 64-bit values
  
  A_SETPOLICY is supposed to work with either 64 or 32-bit values, but due to a
  typo the 64-bit version has never worked correctly.
  
  Submitted by:	aniketp
  Reviewed by:	asomers, cem
  MFC after:	2 weeks
  Sponsored by:	Google, Inc. (GSoC 2018)
  Differential Revision:	https://reviews.freebsd.org/D16222

Modified:
  head/sys/security/audit/audit_syscalls.c

Modified: head/sys/security/audit/audit_syscalls.c
==============================================================================
--- head/sys/security/audit/audit_syscalls.c	Sun Jul 15 21:04:21 2018	(r336318)
+++ head/sys/security/audit/audit_syscalls.c	Sun Jul 15 21:10:19 2018	(r336319)
@@ -251,7 +251,7 @@ sys_auditon(struct thread *td, struct auditon_args *ua
 	case A_OLDSETPOLICY:
 	case A_SETPOLICY:
 		if (uap->length == sizeof(udata.au_policy64)) {
-			if (udata.au_policy & (~AUDIT_CNT|AUDIT_AHLT|
+			if (udata.au_policy & ~(AUDIT_CNT|AUDIT_AHLT|
 			    AUDIT_ARGV|AUDIT_ARGE))
 				return (EINVAL);
 			audit_fail_stop = ((udata.au_policy64 & AUDIT_CNT) ==



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201807152110.w6FLAKhR001741>