Date: Mon, 1 May 2017 16:43:36 +0000 From: "grehan (Peter Grehan)" <phabric-noreply@FreeBSD.org> To: freebsd-virtualization@freebsd.org Subject: [Differential] D10540: vmx: explicit checking for necessary invvpid/invept types Message-ID: <f912c2b4ce116c00a460616162d38eac@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-dvcgq67pzsk2bfph2tq5-req@FreeBSD.org> References: <differential-rev-PHID-DREV-dvcgq67pzsk2bfph2tq5-req@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
grehan added inline comments. INLINE COMMENTS > ept.c:68 > + (((cap) & INVEPT_REQUIRED_TYPES_MASK) == INVEPT_REQUIRED_TYPES_MASK) > > #define EPT_PWLEVELS 4 /* page walk levels */ Might be worth splitting these out into individual tests, since I have a change that will look at the EPT capabilities individually (for PR 203994, bhyve as a KVM guest. Jan - judging from your work in https://patchwork.kernel.org/project/kvm/list/?submitter=170053 you are intimately familiar with this issue :) REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D10540 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: jan.dakinevich_gmail.com, grehan, neel Cc: novel, anish, imp, freebsd-virtualization-listhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f912c2b4ce116c00a460616162d38eac>