Date: Sun, 18 Dec 2016 17:49:07 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Ed Schouten <ed@nuxi.nl> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r310232 - head/sys/dev/mlx4/mlx4_ib Message-ID: <D6E65C71-69F6-4D10-8435-B0924C973293@FreeBSD.org> In-Reply-To: <CABh_MKkkKyX_H0Kom1Q8t_RNj_ZNa4m5ph0566hssQR%2Bi0sCEQ@mail.gmail.com> References: <201612181521.uBIFLcB3030383@repo.freebsd.org> <CABh_MKkkKyX_H0Kom1Q8t_RNj_ZNa4m5ph0566hssQR%2Bi0sCEQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 18 Dec 2016, at 17:37, Ed Schouten <ed@nuxi.nl> wrote: > > 2016-12-18 16:21 GMT+01:00 Dimitry Andric <dim@freebsd.org>: >> Modified: head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c >> ============================================================================== >> --- head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c Sun Dec 18 15:10:08 2016 (r310231) >> +++ head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c Sun Dec 18 15:21:38 2016 (r310232) >> @@ -79,7 +79,7 @@ static ssize_t store_admin_alias_guid(st >> container_of(attr, struct mlx4_ib_iov_sysfs_attr, dentry); >> struct mlx4_ib_iov_port *port = mlx4_ib_iov_dentry->ctx; >> struct mlx4_ib_dev *mdev = port->dev; >> - u64 sysadmin_ag_val; >> + unsigned long long sysadmin_ag_val; >> >> record_num = mlx4_ib_iov_dentry->entry_num / 8; >> guid_index_in_rec = mlx4_ib_iov_dentry->entry_num % 8; > > Looking at the code, the intent is that an actual 64-bit integer is > parsed; not an unsigned long long. What's wrong with using > inttypes.h's SCNx64? That is how I originally submitted it in the review, though with <machine/_inttypes.h>, as it is most often used in kernel sources. However, see Hans's comment in the review here: https://reviews.freebsd.org/D8831#182872 I don't mind either way. -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlhWvg8ACgkQsF6jCi4glqNdGACgqVHhTleeOATnuSWQbK+kIaE0 ti8AoJhwK0REdVCFsAEzsQ1v+GFsWJ5z =WPK8 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D6E65C71-69F6-4D10-8435-B0924C973293>