Date: Mon, 4 Jul 2011 13:43:12 +0200 From: Ulrich Spoerlein <uqs@FreeBSD.org> To: Ed Schouten <ed@80386.nl> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r223715 - head/contrib/gcc Message-ID: <20110704114312.GC8485@acme.spoerlein.net> In-Reply-To: <20110704112437.GT71453@hoeg.nl> References: <201107012045.p61Kju11005984@svn.freebsd.org> <20110704112437.GT71453@hoeg.nl>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Mon, 04.07.2011 at 13:24:37 +0200, Ed Schouten wrote:
> Hi Uli,
>
> * Ulrich Spoerlein <uqs@FreeBSD.org>, 20110701 22:45:
> > - Port -Wtrampolines support from gcc3.
>
> Some testing here seems to suggest it's quite hard to write code that
> triggers this warning, while still passing WARNS >= 3. But still, I
> think it would be good to add this flag to bsd.sys.mk.
>
> I've run a `make universe' and it can be added to WARNS >= 2 without
> breaking the build. Maybe we should add it after we have MFCd this
> commit back to 8?
There are a couple of ports that are using our make and some of them
might even set WARNS, so I fear this would also need an exp-run to see
if there's any fallout there.
Otherwise, I think it's a good idea. Which WARNS<2 parts of our tree
would trigger that warning, btw?
Uli
% find . -name Makefile\* -exec grep WARNS {} +
./benchmarks/raidtest/files/Makefile:WARNS?= 6
./databases/sybtcl/files/Makefile.bsd:WARNS?= 2
./graphics/gdtclft/files/Makefile.bsd:WARNS = 2
./graphics/libfpx/files/Makefile.bsd:WARNS= 3
./graphics/libfpx/Makefile:# (based on WARNS= in particular) instead of being influenced by
./shells/v7sh/files/Makefile:WARNS?= 6
./sysutils/ffs2recov/Makefile: WARNS=0
./sysutils/k8temp/Makefile: @${REINPLACE_CMD} -e 's|WARNS=.*[6-9]|WARNS=5|g' ${WRKSRC}/Makefile
./sysutils/k8temp/Makefile:WARNS= 6
./sysutils/lookupd/Makefile:MAKE_ENV= WARNS=0
./textproc/tclExpat/files/Makefile:WARNS= 3
./www/mod_dtcl/files/Makefile.bsd:WARNS= 2
PS: That does not include ports, using our make and setting WARNS in the
Makefile that they ship with ...
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
iQEcBAEBAgAGBQJOEadQAAoJEKOmmGRKr4LOTD8IAK26r/0qtGjYARnlO1fF8L5p
iFjIOngvQ/srYMjIX1AjGTLrvEkZ5ERTDVFDGaELpSjfCljDRuuGdkdM0sVg7IU7
qVTGV4PN0fdbPUhOelk/CMVdjy0D0cSJAtEzq66SnKiQL0HJiOGMbpnrvPmo9Kuy
WW97XOgYbMRVpKyVNd5yc3NBf6sjm0+MdRHPZZc0LMmstxihP4AgKmGBbe3lg4I9
S5MFBZVIZRpwPhLBnTShRkdFso6k0nveGZnbSqJv7vKYaBZC/Ro02yIez+IDS0Oh
XDJYp3fefreKCpcQc0KCs9zP+Sy8VMgJC1L4XIx0xYMFpaHcdCX12TfTaw59JC8=
=GFWY
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110704114312.GC8485>