Date: Fri, 28 Apr 2006 03:14:58 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: John-Mark Gurney <jmg@FreeBSD.org>, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sched_4bsd.c Message-ID: <20060428025437.N18169@delplex.bde.org> In-Reply-To: <20060427102026.GC20828@garage.freebsd.pl> References: <200604261942.k3QJgdnb086990@repoman.freebsd.org> <20060427102026.GC20828@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 27 Apr 2006, Pawel Jakub Dawidek wrote:
> On Wed, Apr 26, 2006 at 07:42:39PM +0000, John-Mark Gurney wrote:
> +> jmg 2006-04-26 19:42:38 UTC
> +>
> +> FreeBSD src repository
> +>
> +> Modified files:
> +> sys/kern sched_4bsd.c
> +> Log:
> +> move remaining sysctl into the kern.sched tree...
> [...]
> +> -SYSCTL_INT(_kern, OID_AUTO, ccpu, CTLFLAG_RD, &ccpu, 0, "");
> +> +SYSCTL_INT(_kern_sched, OID_AUTO, ccpu, CTLFLAG_RD, &ccpu, 0, "");
> [...]
>
> Too fast.
Just a bug.
> # grep -r kern.ccpu /usr/src/
> /usr/src/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_processor_tbl.c: if (sysctlbyname("kern.ccpu", &ccpu, &len, NULL, 0) == -1) {
> /usr/src/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_processor_tbl.c: syslog(LOG_ERR, "hrProcessorTable: sysctl(kern.ccpu) failed");
> /usr/src/usr.bin/systat/pigs.c: err = sysctlbyname("kern.ccpu", &ccpu, &len, NULL, 0);
> /usr/src/usr.bin/systat/pigs.c: perror("kern.ccpu");
> /usr/src/usr.bin/top/machine.c: GETSYSCTL("kern.ccpu", ccpu);
> /usr/src/bin/ps/nlist.c: if (sysctlbyname("kern.ccpu", &ccpu, &oldlen, NULL, 0) == -1)
grep -r "kern.*ccpu" would also have shown SYSCTL_INT(_kern, ..., ccpu)
in sched_ule.c. I.e., the applications still work with SCHED_ULE.
grep in my old NetBSD source tree showed ccpu/KERN_CCPU under kern.
grep in my old ports tree didn't show any matches.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060428025437.N18169>