Date: Mon, 10 Jan 2005 09:50:19 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Jose M Rodriguez <josemi@freebsd.jazztel.es> Cc: x11@freebsd.org Subject: Re: Xorg ICE vs. Xfce4 (4.2-RC3) needs fixing /etc/rc.d/cleartmp Message-ID: <20050110175019.GA15907@odin.ac.hmc.edu> In-Reply-To: <41E16B3C.30302@redesjm.local> References: <41DDC4F2.5090709@yahoo.com> <20050107003806.GA14003@odin.ac.hmc.edu> <41DE5242.4030606@redesjm.local> <20050107182024.GB30931@odin.ac.hmc.edu> <41E16B3C.30302@redesjm.local>
next in thread | previous in thread | raw e-mail | index | archive | help
--oyUTqETQ0mS9luUI
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Jan 09, 2005 at 06:34:52PM +0100, Jose M Rodriguez wrote:
> Brooks Davis escribi=F3:
>=20
> >On Fri, Jan 07, 2005 at 10:11:30AM +0100, Jose M Rodriguez wrote:
> >=20
> >
> >>Brooks Davis escribi=F3:
> >>
> >> =20
> >>
> >>>Could you please try the following patch? It does the same thing, but
> >>>gives the inode paranoid a way to disable the creation of these
> >>>directories or only create the ones they need.
> >>>
> >>>-- Brooks
> >>>
> >>>Index: rc.d/cleartmp
> >>>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >>>RCS file: /usr/cvs/src/etc/rc.d/cleartmp,v
> >>>retrieving revision 1.11
> >>>diff -u -p -r1.11 cleartmp
> >>>--- rc.d/cleartmp 7 Oct 2004 13:55:25 -0000 1.11
> >>>+++ rc.d/cleartmp 7 Jan 2005 00:31:51 -0000
> >>>@@ -35,5 +35,7 @@ run_rc_command "$1"
> >>># restarting X
> >>>#
> >>>rm -f /tmp/.X[0-9]-lock
> >>>-rm -fr /tmp/.X11-unix
> >>>-mkdir -m 1777 /tmp/.X11-unix
> >>>+if [ -n ${clear_tmp_xdirs} ]; then
> >>>+ rm -fr ${clear_tmp_xdirs}
> >>>+ mkdir -m 1777 ${clear_tmp_xdirs}
> >>>+fi
> >>>Index: defaults/rc.conf
> >>>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >>>RCS file: /usr/cvs/src/etc/defaults/rc.conf,v
> >>>retrieving revision 1.235
> >>>diff -u -p -r1.235 rc.conf
> >>>--- defaults/rc.conf 15 Dec 2004 12:39:28 -0000 1.235
> >>>+++ defaults/rc.conf 7 Jan 2005 00:30:49 -0000
> >>>@@ -443,6 +443,8 @@ linux_enable=3D"NO" # Linux binary compati
> >>>svr4_enable=3D"NO" # SysVR4 emulation loaded at startup (or NO).
> >>>osf1_enable=3D"NO" # Alpha OSF/1 emulation loaded at startup (or NO).
> >>>clear_tmp_enable=3D"NO" # Clear /tmp at startup.
> >>>+clear_tmp_xdirs=3D"/tmp/.X11-unix /tmp/.font-unix /tmp/.ICE-unix"
> >>>+ # Directories needed by X11
> >>>ldconfig_insecure=3D"NO" # Set to YES to disable ldconfig security=20
> >>>checks
> >>>ldconfig_paths=3D"/usr/lib/compat /usr/X11R6/lib /usr/local/lib=20
> >>>/usr/local/lib/compat/pkg"
> >>> # shared library search paths
> >>>
> >>>
> >>>
> >>> =20
> >>>
> >>I recall putting this in a conf PR, try a follow-up.
> >>
> >>But I think your patch is a little bit wrong
> >>
> >>I never like the way X11 is taken by /etc/rc.d/cleartmp. none must b=
e=20
> >>do after the run_rc_command.
> >> =20
> >>
> >
> >That's easy enough to fix.
> >
> >=20
> >
> >>If we need do this from the base system (Thing that I doubt more and=20
> >>more), this must be implementing a new /etc/rc.d/clearx11tmp (this may=
=20
> >>be do in the main /etc/rc.d/cleartmp, like in sendmail), with all the=
=20
> >>bits:
> >>clear_x11tmp_enable, clear_x11tmp_dirs, ...
> >>
> >>But I must point that:
> >>
> >>X11 is now mostly a ports thing, not a base system component. If this=
=20
> >>can be take from ports (I send-pr this also), this must be the path to=
=20
> >>the solution. I put a simple script from libs, but I can work and rcNG=
=20
> >>enabled thing if prefered.
> >>
> >>This is not what x11 really needs. x11 only needs some like this: mkdi=
r=20
> >>-p ... && chown root:wheel ... && chmod 01777 ... . this may be=20
> >>prefered by the x11 team.
> >>
> >>This can be taken both from base and ports without too much problem. =
=20
> >>The only secondary effect of this I know is that you may polite /tmp=20
> >>entries twice, with is not a real pain to the whole boot process.
> >> =20
> >>
> >
> >My worry with using your patch is that localpkg is run quite late in the
> >startup process, well after X may have tried to start if xdm is run from
> >/etc/ttys. If package startup scripts could run anywhere in the order,
> >a script in the port would be obvious solution, but that's not the case.
> >
> You're molsty wrong. init launch gettys after rc has finished (and also=
=20
> localpkg).
You are correct. According to "The Design and Implementation of the
FreeBSD Operating System" init does not spawn processes ttys until after
/etc/rc exits sucessfully. Good luck getting your port commited, I'm
done with this issue.
-- Brooks
--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4
--oyUTqETQ0mS9luUI
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQFB4sBaXY6L6fI4GtQRAopRAKCv9tX9Dc2Qa6R/ztD+roK+OjJMdACePg87
8UfuVHbxkY6/+k7mNyJTMnU=
=ZdJP
-----END PGP SIGNATURE-----
--oyUTqETQ0mS9luUI--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050110175019.GA15907>