Date: Thu, 23 May 2002 10:34:37 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: John Baldwin <jhb@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/include cpufunc.h src/sys/kern kern_mutex.c Message-ID: <20020523073437.GC35465@sunbay.com> In-Reply-To: <20020523171421.L12695-100000@gamplex.bde.org> References: <200205222032.g4MKWdl17723@freefall.freebsd.org> <20020523171421.L12695-100000@gamplex.bde.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Thu, May 23, 2002 at 05:21:49PM +1000, Bruce Evans wrote: > On Wed, 22 May 2002, John Baldwin wrote: > > > jhb 2002/05/22 13:32:39 PDT > > > > Modified files: > > sys/i386/include cpufunc.h > > sys/kern kern_mutex.c > > Log: > > Rename pause() to ia32_pause() so it doesn't conflict with the pause() > > function defined in <unistd.h>. I didn't #ifdef _KERNEL it because the > > mutex implementation in libpthread will probably need this. > > This shoots the messenger. The main bug is gross namespace pollution in > <vgl.h>: > > %%% > #ifndef _VGL_H_ > #define _VGL_H_ > > #include <stdlib.h> > #include <unistd.h> > #include <string.h> > #include <machine/cpufunc.h> > %%% > > <machine/cpufunc.h> is really a kernel-only header, but it sometimes gets > abused in userland. I think this shouldn't be supported. It contains > mostly very machine-dependent interfaces, so it should be used in at most > the implementation of libvgl. libvgl uses i386 interfaces unconditionally, > so it only works on i386's, but this limitation is not documented. > Would you like me to fix this by adding the share/man/man3/i386, and installing this manpage to there? Cheers, -- Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQE87JuNUkv4P6juNwoRAin4AKCMXwdU6cygDOXLhpB9IBVuX3NBCQCfTgRl MM96cbDiHKzz0j+lUiHFLqM= =ojix -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020523073437.GC35465>