Date: Fri, 11 Jun 2004 21:16:06 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: current@FreeBSD.org Subject: Re: kernel dev_t elimination patch for review Message-ID: <20040611210929.J13443@gamplex.bde.org> In-Reply-To: <69020.1086934568@critter.freebsd.dk> References: <69020.1086934568@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 11 Jun 2004, Poul-Henning Kamp wrote: > http://phk.freebsd.dk/patch/dev_t.patch > > This patch changes "dev_t" in the kernel to "struct cdev *" > and is 337K of boredom like: > > -static dev_t perfdev; > +static struct cdev *perfdev; > > People who maintain cross-platform or cross-version source code in > the kernel, should take a close look at this patch. > > If you don't like the way I have done it (which is mostly automated) > you are more than welcome to commit your own patch, all you have > to do is use "struct cdev *" instead of "dev_t", and you can do > that already now. This mangles the formatting in approximately 10% of cases (mainly for dev_t\t\t and for almost all dev_t's in structs; in structs it tends to misindent both the member name and the comment). Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040611210929.J13443>