Date: Mon, 1 Jun 2020 08:14:49 +0000 From: "markm (Mark R V Murray)" <phabric-noreply@FreeBSD.org> To: Phabricator <phabric-noreply@FreeBSD.org> Cc: freebsd-net@freebsd.org Subject: [Differential] D24989: netinet: Generate a random RSS key on boot. Message-ID: <745f851a2a661525a533143990a9b7bd@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-yukac7sf5rncf2mc6vjo-req@reviews.freebsd.org>
index | next in thread | previous in thread | raw e-mail
markm requested changes to this revision. markm added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > rss_config.c:251 > */ > + arc4random_buf(rss_key, RSS_KEYSIZE); > } This scares me less than the previously hard-coded key, but if we are going to the trouble to randomise, then we need to sequence it properly. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D24989/new/ REVISION DETAIL https://reviews.freebsd.org/D24989 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: neel_neelc.org, #csprng, markm Cc: markm, cem, #csprng, kevans, debdrup, rwatson, imp, ae, melifaro, #contributor_reviews_base, freebsd-net-list, mmacy, kpraveen.lkml_gmail.com, marcnarc_gmail.com, simonvella_gmail.com, novice_techie.com, tommi.pernila_iki.fi, krzysztof.galazka_intel.comhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?745f851a2a661525a533143990a9b7bd>