Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 5 Dec 2020 10:55:09 +0000 (UTC)
From:      Michal Meloun <mmel@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r368364 - head/sys/dev/pci
Message-ID:  <202012051055.0B5At9cN078370@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mmel
Date: Sat Dec  5 10:55:09 2020
New Revision: 368364
URL: https://svnweb.freebsd.org/changeset/base/368364

Log:
  DesignWare PCIe driver: Don't call bus_generic_attach() twice.
  bus_generic_attach() should be called from the attach function of the real
  implementation, not from the common init function.
  
  MFC after:	1 week

Modified:
  head/sys/dev/pci/pci_dw.c

Modified: head/sys/dev/pci/pci_dw.c
==============================================================================
--- head/sys/dev/pci/pci_dw.c	Sat Dec  5 10:10:25 2020	(r368363)
+++ head/sys/dev/pci/pci_dw.c	Sat Dec  5 10:55:09 2020	(r368364)
@@ -640,7 +640,7 @@ pci_dw_init(device_t dev)
 
 	device_add_child(dev, "pci", -1);
 
-	return (bus_generic_attach(dev));
+	return (0);
 out:
 	/* XXX Cleanup */
 	return (rv);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202012051055.0B5At9cN078370>