Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Oct 2018 15:43:21 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r339731 - head/sys/kern
Message-ID:  <201810251543.w9PFhLq3083651@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: markj
Date: Thu Oct 25 15:43:21 2018
New Revision: 339731
URL: https://svnweb.freebsd.org/changeset/base/339731

Log:
  Add FALLTHROUGH comments to appease Coverity.
  
  CID:		1017862-1017864, 1017866-1017868
  MFC after:	2 weeks

Modified:
  head/sys/kern/kern_environment.c
  head/sys/kern/vfs_mount.c

Modified: head/sys/kern/kern_environment.c
==============================================================================
--- head/sys/kern/kern_environment.c	Thu Oct 25 15:41:26 2018	(r339730)
+++ head/sys/kern/kern_environment.c	Thu Oct 25 15:43:21 2018	(r339731)
@@ -839,10 +839,13 @@ getenv_quad(const char *name, quad_t *data)
 	switch (vtp[0]) {
 	case 't': case 'T':
 		iv *= 1024;
+		/* FALLTHROUGH */
 	case 'g': case 'G':
 		iv *= 1024;
+		/* FALLTHROUGH */
 	case 'm': case 'M':
 		iv *= 1024;
+		/* FALLTHROUGH */
 	case 'k': case 'K':
 		iv *= 1024;
 	case '\0':

Modified: head/sys/kern/vfs_mount.c
==============================================================================
--- head/sys/kern/vfs_mount.c	Thu Oct 25 15:41:26 2018	(r339730)
+++ head/sys/kern/vfs_mount.c	Thu Oct 25 15:43:21 2018	(r339731)
@@ -1647,17 +1647,16 @@ vfs_getopt_size(struct vfsoptlist *opts, const char *n
 	if (iv < 0)
 		return (EINVAL);
 	switch (vtp[0]) {
-	case 't':
-	case 'T':
+	case 't': case 'T':
 		iv *= 1024;
-	case 'g':
-	case 'G':
+		/* FALLTHROUGH */
+	case 'g': case 'G':
 		iv *= 1024;
-	case 'm':
-	case 'M':
+		/* FALLTHROUGH */
+	case 'm': case 'M':
 		iv *= 1024;
-	case 'k':
-	case 'K':
+		/* FALLTHROUGH */
+	case 'k': case 'K':
 		iv *= 1024;
 	case '\0':
 		break;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201810251543.w9PFhLq3083651>