Date: Fri, 31 Oct 2025 12:38:29 -0700 From: Mark Millard <marklmi@yahoo.com> To: Dimitry Andric <dim@FreeBSD.org>, dev-commits-src-main <dev-commits-src-main@freebsd.org> Subject: RE: git: 51e8e8b0f369 - main - Merge commit e24f90190c77 from llvm git (by Brad Smith): Message-ID: <0F63F7C2-9C1C-4FF6-A165-76F15E72BEF4@yahoo.com>
index | next in thread | raw e-mail
Dimitry Andric <dim_at_FreeBSD.org> wrote on Date: Fri, 31 Oct 2025 15:48:04 UTC : > On 31 Oct 2025, at 14:48, Jose Luis Duran <jlduran@FreeBSD.org> wrote: > > > > On Wed, Oct 29, 2025 at 3:50 PM Dimitry Andric <dim@freebsd.org> wrote: > >> > >> The branch main has been updated by dim: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=51e8e8b0f36933814b1be08913857727876aece5 > >> > >> commit 51e8e8b0f36933814b1be08913857727876aece5 > >> Author: Dimitry Andric <dim@FreeBSD.org> > >> AuthorDate: 2025-10-29 18:49:54 +0000 > >> Commit: Dimitry Andric <dim@FreeBSD.org> > >> CommitDate: 2025-10-29 18:49:54 +0000 > >> > >> Merge commit e24f90190c77 from llvm git (by Brad Smith): > >> > >> [Driver] Enable outline atomics for FreeBSD/aarch64 (#156089) > >> > >> The compiler_rt helper functions have been built since 12.4, 13.1, 14 > >> and anything newer. > >> > >> MFC after: 3 days > >> --- > >> contrib/llvm-project/clang/lib/Driver/ToolChains/FreeBSD.h | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/contrib/llvm-project/clang/lib/Driver/ToolChains/FreeBSD.h b/contrib/llvm-project/clang/lib/Driver/ToolChains/FreeBSD.h > >> index 7ab63905ed4f..7d090ba682b3 100644 > >> --- a/contrib/llvm-project/clang/lib/Driver/ToolChains/FreeBSD.h > >> +++ b/contrib/llvm-project/clang/lib/Driver/ToolChains/FreeBSD.h > >> @@ -78,6 +78,11 @@ public: > >> void AddHIPIncludeArgs(const llvm::opt::ArgList &DriverArgs, > >> llvm::opt::ArgStringList &CC1Args) const override; > >> > >> + bool IsAArch64OutlineAtomicsDefault( > >> + const llvm::opt::ArgList &Args) const override { > >> + return true; > >> + } > >> + META_MODE can not really track all the consequences, especially for files that do not include clang/lib/Driver/ToolChains/FreeBSD.h . So rebuilds need to be forced. > >> UnwindTableLevel > >> getDefaultUnwindTableLevel(const llvm::opt::ArgList &Args) const override; > >> bool isPIEDefault(const llvm::opt::ArgList &Args) const override; > > > > I'm sure you're probably aware by now, but aarch64 builds are failing > > after this commit: > > > > https://ci.freebsd.org/job/FreeBSD-main-aarch64-build/33100/ > > It's weird, but I cannot reproduce it. For me, both world and kernel build fine. Yea, it s not the typical sort of source dependency. META_MODE did not rebuild everything needed so, apparently, you still had inline Atomics. Having toolchain updates rebuild everything dependent all the time has its own issues to be avoided. > Does anybody have any particular settings that can be used to reproduce this on a fresh 16-CURRENT or 15-STABLE box? Separately: Sorry for my earlier misleading reference to armv7. Turns to be a separate change elsewhere that lead to those failures. === Mark Millard marklmi at yahoo.comhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0F63F7C2-9C1C-4FF6-A165-76F15E72BEF4>