Date: Fri, 22 Nov 2019 04:23:27 +0000 From: Glen Barber <gjb@freebsd.org> To: Brooks Davis <brooks@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, FreeBSD Ports Management Team <portmgr@freebsd.org>, Colin Percival <cperciva@freebsd.org> Subject: Re: svn commit: r354909 - in head: . share/mk Message-ID: <20191122042327.GQ5599@FreeBSD.org> In-Reply-To: <20191121211127.GC50024@spindle.one-eyed-alien.net> References: <201911201836.xAKIawWt053874@repo.freebsd.org> <20191121161337.GA92849@FreeBSD.org> <20191121211127.GC50024@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--xYEXny2b0/vlBQCR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 21, 2019 at 09:11:27PM +0000, Brooks Davis wrote: > On Thu, Nov 21, 2019 at 04:13:37PM +0000, Glen Barber wrote: > > On Wed, Nov 20, 2019 at 06:36:58PM +0000, Brooks Davis wrote: > > > Author: brooks > > > Date: Wed Nov 20 18:36:58 2019 > > > New Revision: 354909 > > > URL: https://svnweb.freebsd.org/changeset/base/354909 > > >=20 > > > Log: > > > Make the warning for deprecated NO_ variables an error. > > > =20 > > > Support for NO_CTF, NO_DEBUG_FILES, NO_INSTALLLIB, NO_MAN, NO_PROFI= LE, > > > and NO_WARNS as deprecated in 2014 with a warning added for each one > > > found. Turn these into error in preperation for removal of compatab= ility > > > support before FreeBSD 13. > > > =20 > > > Reviewed by: imp > > > Relnotes: yes > > > Sponsored by: DARPA, AFRL > > > Differential Revision: https://reviews.freebsd.org/D22448 > > >=20 > >=20 > > > Modified: head/share/mk/bsd.opts.mk > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- head/share/mk/bsd.opts.mk Wed Nov 20 18:12:01 2019 (r354908) > > > +++ head/share/mk/bsd.opts.mk Wed Nov 20 18:36:58 2019 (r354909) > > > @@ -100,7 +100,7 @@ __DEFAULT_DEPENDENT_OPTIONS =3D \ > > > PROFILE \ > > > WARNS > > > .if defined(NO_${var}) > > > -.warning "NO_${var} is defined, but deprecated. Please use MK_${var}= =3Dno instead." > > > +.error "NO_${var} is defined, but deprecated. Please use MK_${var}= =3Dno instead." > > > MK_${var}:=3Dno > > > .endif > > > .endfor > > >=20 > >=20 > > Had this been exp-run tested? This breaks at least the > > net/bsdec2-image-upload port, which does *not* set NO_MAN explicitly in > > its Makefile. I suspect at least several other ports are now implicitly > > broken as result of this change. >=20 > No, it wasn't. I didn't realize it was needed. I could revert if > there's significant fallout. I've patched net/bsdec2-image-upload and > I'm testing a patch for emulators/open-vm-tools. >=20 > In general the issue is people putting NO_MAN=3D in Makefiles that > the freebsd build infrastructure and then never looking at build > output. In some cases it's clearly blind copy-and-paste (e.g. > emulators/open-vm-tools sets NO_MAN and NOMAN in a kmod Makefile where > they do nothing). >=20 > Ideally I'd like to suppress these errors in ports unless DEVELOPER is > defined, but I'm not sure how best to do that. >=20 Have you seen the email from antoine in reply to your commit to the net/bsdec2-image-upload commit? Glen --xYEXny2b0/vlBQCR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAl3XYroACgkQAxRYpUeP 4pOGzg//YVQVDLv0RlLudB3ZUsw34dF+fQNub+LUvSz3nSuZBlSezXu+lzvmKVmC Otob7LAqMVH6xWmDL6cs3y/Wnp1piIEWKHB2ylADGRu9Fm/9Huz/jubOD3W9/CDV kkzYBrNY7qaqikwMjL1PVUzvAGPE3C4+q20wiVtKXTS7bq89B8+WwrbKfDfL2Crx 7PT1gWd7SRULE32fBZxjb46n2WP0K/SqJab/XfGXlxnpt8bCuPkxeWZxY7I/spdZ ASoYN8GKugu0/r0iniTuPAFRLdigUbhYUzjHJajkEcVeOKC464zZmPqpvt9HvM3c VFjloAMf0t7HmFW0jt9jl3wweyaJRN1u+zZwT3ASN84dy58pm6NEhxOuN7ZKarDd DAq/qzF2RPYJALlVli6B+vqmYI1sDLPymS76rmsZygRIpv9AT3F5qzaKLgAfTjQo K71BroWV8jf9B3+knjeub9sJR4Xz8zoQ/EjN5H4ufzQLhbUKAz/sEO3++Jv55aMe Y0I/vFwRdgqZL6ctgP3ILzqgueSpwLeMKqRZi1+dRBmXXbeLdIAEHTjdJZKoLc3O t8CMKQMMQ85QZYaMLd1svFobYgzWcOr6sI3tNHEL7ThqiEyP5pAIr9gSxFXB3dx1 n3OcFsxIWZApDj0WeFSsd1MKK1hvUEf4pEqROhafS4pniDBOsW4= =+/xo -----END PGP SIGNATURE----- --xYEXny2b0/vlBQCR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191122042327.GQ5599>