Date: Wed, 11 Jun 2025 23:19:52 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Rick Macklem <rick.macklem@gmail.com>, Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 79d0f4474653 - main - rpcbind: Ensure krpc is present. Message-ID: <aEpxiA5QoWGtYYdN@cell.glebi.us> In-Reply-To: <aEkAmW-ZNSENrp7h@kib.kiev.ua> References: <aEbKLniIuHd4xuq7@kib.kiev.ua> <CAM5tNy7uGWg4gOsy%2BM7_vneObuszzxNhGAJF-6rd%2Byjqc00QeA@mail.gmail.com> <aEbPE5oG47SuN2y0@kib.kiev.ua> <CAM5tNy6-xtDYQPw6vr588e2r=tX76pWZnKPczwaCrZ5j5XnCEw@mail.gmail.com> <aEdJQybzSOzR3BS0@cell.glebi.us> <aEd5lozkABjyg0UZ@kib.kiev.ua> <aEegKoTN-ej0C5_Z@cell.glebi.us> <aEf2tqXgHDo8SMBb@kib.kiev.ua> <aEhSOKKsHqfaFlNZ@cell.glebi.us> <aEkAmW-ZNSENrp7h@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 11, 2025 at 07:05:45AM +0300, Konstantin Belousov wrote:
K> On Tue, Jun 10, 2025 at 08:41:44AM -0700, Gleb Smirnoff wrote:
K> > On Tue, Jun 10, 2025 at 12:11:18PM +0300, Konstantin Belousov wrote:
K> > K> Apparently we already have the feature called 'warmstart', where rpcbind
K> > K> can be restarted and existing registrations are reloaded. So it is in
K> > K> fact already solved, assuming admin is careful enough to use -w.
K> >
K> > Ok, then all that needs to be done is revert this:
K> >
K> > --- a/usr.sbin/rpcbind/rpcbind.c
K> > +++ b/usr.sbin/rpcbind/rpcbind.c
K> > @@ -159,10 +159,6 @@ main(int argc, char *argv[])
K> >
K> > update_bound_sa();
K> >
K> > - /* Ensure krpc is loaded */
K> > - if (modfind("krpc") < 0 && kldload("krpc") < 0)
K> > - err(1, "krpc");
K> > -
K> > /* Check that another rpcbind isn't already running. */
K> > if ((rpcbindlockfd = open(RPCBINDDLOCK, O_RDONLY|O_CREAT, 0444)) < 0)
K> > err(1, "%s", RPCBINDDLOCK);
K> Well, absolutely minimal fix would be to change err() to warn().
Kostik, please just commit this. Just one suggestion: make the warn() message
more verbose:
warn("failed to load krpc module, RPC services for kernel disabled");
--
Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aEpxiA5QoWGtYYdN>