Date: Tue, 17 Dec 2024 10:47:58 -0700 From: Warner Losh <imp@bsdimp.com> To: Ruslan Bukin <br@freebsd.org> Cc: Jessica Clarke <jrtc27@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 56816e687557 - main - riscv: Eswin hwreset support added. Message-ID: <CANCZdfqky7C4%2BJTXYVdd2jnEL7RuYWOy64yMM52RPGwdLEwTdQ@mail.gmail.com> In-Reply-To: <Z2G2fA1iv3tVDcSE@bsdpad.com> References: <202412171147.4BHBlAs7010565@gitrepo.freebsd.org> <F35C5308-535A-460F-9076-A1357F022C8F@freebsd.org> <Z2G2fA1iv3tVDcSE@bsdpad.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, Dec 17, 2024, 10:36 AM Ruslan Bukin <br@freebsd.org> wrote: > On Tue, Dec 17, 2024 at 02:39:00PM +0000, Jessica Clarke wrote: > > On 17 Dec 2024, at 11:47, Ruslan Bukin <br@FreeBSD.org> wrote: > > > > > > The branch main has been updated by br: > > > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=56816e68755725371ac89dc5aa882fdce46605a5 > > > > > > commit 56816e68755725371ac89dc5aa882fdce46605a5 > > > Author: Ruslan Bukin <br@FreeBSD.org> > > > AuthorDate: 2024-12-17 11:35:08 +0000 > > > Commit: Ruslan Bukin <br@FreeBSD.org> > > > CommitDate: 2024-12-17 11:46:10 +0000 > > > > > > riscv: Eswin hwreset support added. > > > > > > Add reset controller driver for Eswin EIC7700. > > > > > > This one has two reset cells in FDT, which is unusual, so provide a > > > custom hwreset_map method. > > > > > > Tested on SiFive Premier P550. > > > > > > Reviewed by: mhorne, jrtc27 > > > > I gave one review comment, I didn’t get to approving it. Are you > > writing these manually rather than using (git-)arc?... > > > > Jess > > > > I apologize. I'm using git arc. The comment you left resulted to a > positive impact on the code so I decided to indicate you as well, > despite you did not press Accept. > Discussed-with: I think is the trailer to use for this situation where input was given without final approval. Warner > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Tue, Dec 17, 2024, 10:36 AM Ruslan Bukin <<a href="mailto:br@freebsd.org">br@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Dec 17, 2024 at 02:39:00PM +0000, Jessica Clarke wrote:<br> > On 17 Dec 2024, at 11:47, Ruslan Bukin <br@FreeBSD.org> wrote:<br> > > <br> > > The branch main has been updated by br:<br> > > <br> > > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=56816e68755725371ac89dc5aa882fdce46605a5" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=56816e68755725371ac89dc5aa882fdce46605a5</a><br>; > > <br> > > commit 56816e68755725371ac89dc5aa882fdce46605a5<br> > > Author: Ruslan Bukin <br@FreeBSD.org><br> > > AuthorDate: 2024-12-17 11:35:08 +0000<br> > > Commit: Ruslan Bukin <br@FreeBSD.org><br> > > CommitDate: 2024-12-17 11:46:10 +0000<br> > > <br> > > riscv: Eswin hwreset support added.<br> > > <br> > > Add reset controller driver for Eswin EIC7700.<br> > > <br> > > This one has two reset cells in FDT, which is unusual, so provide a<br> > > custom hwreset_map method.<br> > > <br> > > Tested on SiFive Premier P550.<br> > > <br> > > Reviewed by: mhorne, jrtc27<br> > <br> > I gave one review comment, I didn’t get to approving it. Are you<br> > writing these manually rather than using (git-)arc?...<br> > <br> > Jess<br> > <br> <br> I apologize. I'm using git arc. The comment you left resulted to a<br> positive impact on the code so I decided to indicate you as well,<br> despite you did not press Accept.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Discussed-with: I think is the trailer to use for this situation where input was given without final approval. </div><div dir="auto"><br></div><div dir="auto">Warner </div><div dir="auto"><div class="gmail_quote gmail_quote_container"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> </blockquote></div></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqky7C4%2BJTXYVdd2jnEL7RuYWOy64yMM52RPGwdLEwTdQ>