Date: Mon, 14 May 2007 15:40:40 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: Dag-Erling Smorgrav <des@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 Message-ID: <20070514154040.0lofzrgm8kskgog4@webmail.leidinger.net> In-Reply-To: <200705131815.l4DIFop9026874@repoman.freebsd.org> References: <200705131815.l4DIFop9026874@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Dag-Erling Smorgrav <des@FreeBSD.org> (from Sun, 13 May 2007 =20
18:15:50 +0000 (UTC)):
> des 2007-05-13 18:15:50 UTC
>
> FreeBSD src repository
>
> Modified files:
> . Makefile.inc1
> Log:
> Greatly speed up {check,delete}-old* by replacing make loops with sh loo=
ps.
How much faster? Thanks for tackling this.
Some review:
Why did you remove the echo?
Why do you redirect stderr of chflags to /dev/null?
Why did you change the removal logic?
The way it was before:
- rm (without -i if requested)
- if rm fails do a chflags and rm again (bug: if user says no in the =20
interactive mode, the chlags is done regardless)
- tell the user about the stuff we do (removing flags)
- it aborts on a failure of the second rm (AFAIR)
The way it is now:
- for every file do a chflags without notifying the user, don't tell =20
about problems
- rm (without -i if requested)
- bug(?): ${DESTDIR} in the rm line
- doesn't abort on rm failure
- has the same bug that it chflags even if the user doesn't want to =20
rm the file
Before it was possible for the user to readd the flags, now the user =20
doesn't know about this. I also worry about the abort on failure part =20
which does not exist anymore. The last part was done on purpose, the =20
former part was nice to have (because of the bug) and the printing of =20
what is going on in this part was on purpose.
Bye,
Alexander.
--=20
We read to say that we have read.
http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7
http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070514154040.0lofzrgm8kskgog4>