Date: Tue, 07 Jan 2020 00:36:49 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: Larry Rosenman <ler@FreeBSD.org> Cc: Mathieu Arnold <mat@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org>, Cy Schubert <Cy.Schubert@cschubert.com>, svn-ports-all <svn-ports-all@freebsd.org>, ports-committers <ports-committers@freebsd.org>, Adam Weinberger <adamw@adamw.org> Subject: Re: svn commit: r522273 - in head/sysutils/lsof: . files Message-ID: <36cs-jgxa-wny@FreeBSD.org> In-Reply-To: <77126b0704f82ceb1890e4570fd7b1f5@FreeBSD.org> (Larry Rosenman's message of "Mon, 06 Jan 2020 16:49:37 -0600") References: <202001062042.006Kg81F048249@repo.freebsd.org> <202001062102.006L2KrM089339@slippy.cwsent.com> <ead20a315b008a881dbfb087eb74e6a3@FreeBSD.org> <CAP7rwci11RohkJWGAyZM7Ez0%2BT833M0HUxnV1ZA62VA8B1ZAEg@mail.gmail.com> <20200106224656.wefyervptxppm4pv@atuin.in.mat.cc> <77126b0704f82ceb1890e4570fd7b1f5@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Larry Rosenman <ler@FreeBSD.org> writes: > On 01/06/2020 4:46 pm, Mathieu Arnold wrote: > >> On Mon, Jan 06, 2020 at 02:19:58PM -0700, Adam Weinberger wrote: >>> On Mon, Jan 6, 2020 at 2:05 PM Larry Rosenman <ler@freebsd.org> wrote: >>> > >>> > On 01/06/2020 3:02 pm, Cy Schubert wrote: >>> > > In message <202001062042.006Kg81F048249@repo.freebsd.org>, Larry >>> > > Rosenman >>> > > write >>> > > s: >>> > >> Author: ler >>> > >> Date: Mon Jan 6 20:42:08 2020 >>> > >> New Revision: 522273 >>> > >> URL: https://svnweb.freebsd.org/changeset/ports/522273 >>> > >> >>> > >> Log: >>> > >> sysutils/lsof: fix build following base r356337. >>> > >> >>> > >> I took the patch from 243122 as it was more correct. >>> > >> >>> > >> PR: 243122, 243083 >>> > >> Submitted by: cy, yasu@utahime.org >>> > >> >>> > >> Added: >>> > >> head/sysutils/lsof/files/patch-dialects_freebsd_dnode2.c >>> > >> (contents, props >>> > >> changed) >>> > >> Modified: >>> > >> head/sysutils/lsof/Makefile >>> > >> >>> > >> Modified: head/sysutils/lsof/Makefile >>> > >> ============================================================================= >>> > >> = >>> > >> --- head/sysutils/lsof/Makefile Mon Jan 6 20:25:36 2020 (r52227 >>> > >> 2) >>> > >> +++ head/sysutils/lsof/Makefile Mon Jan 6 20:42:08 2020 (r52227 >>> > >> 3) >>> > >> @@ -3,7 +3,7 @@ >>> > >> >>> > >> PORTNAME= lsof >>> > >> DISTVERSION= 4.93.2 >>> > >> -PORTREVISION= 6 >>> > >> +PORTREVISION= 8 >>> > > >>> > > Was this needed? The package doesn't change, only fixing the build. >>> > > >>> > >> PORTEPOCH= 8 >>> > >> CATEGORIES= sysutils >>> > >> >>> > >> >>> > >>> > I thought build breaks on the cluster needed a port rev bump... >>> The logic is that if the currently-built package needs to change, >>> it >>> requires a bump. If there is no currently-built package because of a >>> build failure, a bump doesn't have a meaningful effect. >> Said in another way, PORTREVISION bumps happen when an existing >> package, >> 4.93.2_6 here, has issues (mostly runtime, but can be other reasons, >> see >> the PHB for full list) and it needs to be upgraded to a newer >> version to >> work correctly, 4.93.2_8 here. >> If 4.93.2_6 never existed because it could not be built, well, the >> most >> anybody ever had was 4.93.2_5, and once 4.93.2_6 finally builds, it >> will >> get updated correctly. > > It did build, then -CURRENT /usr/src changed out from under it and it > broke. > > I think the PORTREVISION bump here was corret. poudriere rebuilds all packages on OSVERSION (aka __FreeBSD_version) bumps. If lsof worked before ABI (or KBI?) break it'd be rebuilt after, anyway.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?36cs-jgxa-wny>