Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 28 Jul 2007 15:00:35 -0400
From:      Joe Marcus Clarke <marcus@FreeBSD.org>
To:        "Steven G. Kargl" <kargl@troutmask.apl.washington.edu>
Cc:        gnome@FreeBSD.org
Subject:   Re: ports/114838: devel/gnome-vfs broken without kerberos
Message-ID:  <1185649236.63289.3.camel@shumai.marcuscom.com>
In-Reply-To: <200707281849.l6SInTQo078788@troutmask.apl.washington.edu>
References:  <200707281849.l6SInTQo078788@troutmask.apl.washington.edu>

next in thread | previous in thread | raw e-mail | index | archive | help

--=-eg+BzIDkAgIyYQJEE5rp
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sat, 2007-07-28 at 11:49 -0700, Steven G. Kargl wrote:
> marcus@FreeBSD.org wrote:
> > Synopsis: devel/gnome-vfs broken without kerberos
> >=20
> > State-Changed-From-To: open->closed
> > State-Changed-By: marcus
> > State-Changed-When: Sat Jul 28 18:03:24 UTC 2007
> > State-Changed-Why:=20
> > Kerberos is part of the default base system, and we do not support
> > builds without it.
> >=20
>=20
> Then the Makefile should check if WITHOUT_KERBEROS is defined,
> and issue an error.

Fair enough.  However, this check will break INDEX builds on machines
that define WITHOUT_KERBEROS (which is legal).  I have committed a
different check which should accomplish the same thing.  The downside of
this approach is that it will not handle WITHOUT_KERBEROS defined in
src.conf only.

Joe

>=20
> --- Makefile.orig       2007-07-26 16:15:53.000000000 -0700
> +++ Makefile    2007-07-26 16:18:37.000000000 -0700
> @@ -58,6 +58,10 @@
>  USE_FAM=3D       yes
>  .endif
> =20
> +.if defined(WITHOUT_KERBEROS)=20
> +.error KERBEROS is required.
> +.endif=20
> +
>  .if exists(${LOCALBASE}/lib/libkrb5.so)
>  LIB_DEPENDS+=3D  krb5:${PORTSDIR}/security/heimdal
>  .endif
>=20
--=20
Joe Marcus Clarke
FreeBSD GNOME Team      ::      gnome@FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome

--=-eg+BzIDkAgIyYQJEE5rp
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)

iD8DBQBGq5JSb2iPiv4Uz4cRAtxoAJ9nrkJ5UJtd3MWe1g4l0bnOpB2h7QCgnGe5
vXqT0o3Gc0Z6Dt5Z6YzL7bU=
=4kT1
-----END PGP SIGNATURE-----

--=-eg+BzIDkAgIyYQJEE5rp--




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1185649236.63289.3.camel>