Date: Mon, 01 Jul 2019 01:15:36 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 238037] [PATCH] Implement ig4 suspend/resume Message-ID: <bug-238037-227-GqLcVzPCYM@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-238037-227@https.bugs.freebsd.org/bugzilla/> References: <bug-238037-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238037 Austin Shafer <ashafer@badland.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204527|0 |1 is obsolete| | --- Comment #5 from Austin Shafer <ashafer@badland.io> --- Created attachment 205447 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=205447&action=edit ig4 suspend/resume patch Thanks for the feedback! I'm glad I could help. You guys are definitely right, I updated my patch with the write barrier changes, and made sure to use IG4_REG_RESETS_SKL for skylake. As for if the barriers are needed, I never really tested but assumed it was required because the `reg_write` wrapper in ig4_iic.c uses it. I added the barriers just to be extra sure that the reset went through to avoid any nastiness on suspend or resume. Please let me know if you have any other advice for things I should change. -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-238037-227-GqLcVzPCYM>