Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 18 Sep 2014 17:22:42 +0000 (UTC)
From:      Will Andrews <will@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r271793 - head/sys/dev/firewire
Message-ID:  <201409181722.s8IHMgj2056971@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: will
Date: Thu Sep 18 17:22:42 2014
New Revision: 271793
URL: http://svnweb.freebsd.org/changeset/base/271793

Log:
  Silence noisy firewire logging.
  
  MFC after:	1 month
  Sponsored by:	Spectra Logic
  MFSpectraBSD:	974594 on 2013/08/02

Modified:
  head/sys/dev/firewire/firewire.c
  head/sys/dev/firewire/fwohci.c

Modified: head/sys/dev/firewire/firewire.c
==============================================================================
--- head/sys/dev/firewire/firewire.c	Thu Sep 18 17:18:42 2014	(r271792)
+++ head/sys/dev/firewire/firewire.c	Thu Sep 18 17:22:42 2014	(r271793)
@@ -1560,8 +1560,6 @@ fw_explore_node(struct fw_device *dfwdev
 	/* First quad */
 	err = fw_explore_read_quads(dfwdev, CSRROMOFF, &csr[0], 1);
 	if (err) {
-		device_printf(fc->bdev, "%s: node%d: explore_read_quads failure\n",
-		    __func__, node);
 		dfwdev->status = FWDEVINVAL;
 		return (-1);
 	}
@@ -1577,15 +1575,11 @@ fw_explore_node(struct fw_device *dfwdev
 	/* bus info */
 	err = fw_explore_read_quads(dfwdev, CSRROMOFF + 0x04, &csr[1], 4);
 	if (err) {
-		device_printf(fc->bdev, "%s: node%d: error reading 0x04\n",
-		    __func__, node);
 		dfwdev->status = FWDEVINVAL;
 		return (-1);
 	}
 	binfo = (struct bus_info *)&csr[1];
 	if (binfo->bus_name != CSR_BUS_NAME_IEEE1394) {
-		device_printf(fc->bdev, "%s: node%d: invalid bus name 0x%08x\n",
-		    __func__, node, binfo->bus_name);
 		dfwdev->status = FWDEVINVAL;
 		return (-1);
 	}
@@ -1668,10 +1662,6 @@ fw_explore_node(struct fw_device *dfwdev
 			STAILQ_INSERT_HEAD(&fc->devices, fwdev, link);
 		else
 			STAILQ_INSERT_AFTER(&fc->devices, pfwdev, fwdev, link);
-
-		device_printf(fc->bdev, "New %s device ID:%08x%08x\n",
-		    linkspeed[fwdev->speed],
-		    fwdev->eui.hi, fwdev->eui.lo);
 	} else {
 		fwdev->dst = node;
 		fwdev->status = FWDEVINIT;
@@ -1828,9 +1818,6 @@ fw_attach_dev(struct firewire_comm *fc)
 				 * Remove devices which have not been seen
 				 * for a while.
 				 */
-				device_printf(fc->bdev, "%s:"
-					"Removing missing device ID:%08x%08x\n",
-					__func__, fwdev->eui.hi, fwdev->eui.lo);
 				STAILQ_REMOVE(&fc->devices, fwdev, fw_device,
 				    link);
 				free(fwdev, M_FW);

Modified: head/sys/dev/firewire/fwohci.c
==============================================================================
--- head/sys/dev/firewire/fwohci.c	Thu Sep 18 17:18:42 2014	(r271792)
+++ head/sys/dev/firewire/fwohci.c	Thu Sep 18 17:22:42 2014	(r271793)
@@ -1126,12 +1126,10 @@ fwohci_txd(struct fwohci_softc *sc, stru
 		case FWOHCIEV_ACKBSA:
 		case FWOHCIEV_ACKBSB:
 		case FWOHCIEV_ACKBSX:
-			device_printf(sc->fc.dev, "txd err=%2x %s\n", stat, fwohcicode[stat]);
 			err = EBUSY;
 			break;
 		case FWOHCIEV_FLUSHED:
 		case FWOHCIEV_ACKTARD:
-			device_printf(sc->fc.dev, "txd err=%2x %s\n", stat, fwohcicode[stat]);
 			err = EAGAIN;
 			break;
 		case FWOHCIEV_MISSACK:
@@ -1145,8 +1143,6 @@ fwohci_txd(struct fwohci_softc *sc, stru
 		case FWOHCIEV_ACKDERR:
 		case FWOHCIEV_ACKTERR:
 		default:
-			device_printf(sc->fc.dev, "txd err=%2x %s\n",
-							stat, fwohcicode[stat]);
 			err = EINVAL;
 			break;
 		}

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201409181722.s8IHMgj2056971>