Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 1 Jun 2018 16:23:47 +0000 (UTC)
From:      Alan Somers <asomers@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r334487 - head/tests/sys/audit
Message-ID:  <201806011623.w51GNlY6008654@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: asomers
Date: Fri Jun  1 16:23:47 2018
New Revision: 334487
URL: https://svnweb.freebsd.org/changeset/base/334487

Log:
  audit(4): Add tests for the fw class of syscalls.
  
  truncate and ftruncate are the only syscalls in this class, apart from
  certain variations of open and openat, which will be handled in a different
  file.
  
  Submitted by:	aniketp
  MFC after:	2 weeks
  Sponsored by:	Google, Inc. (GSoC 2018)
  Differential Revision:	https://reviews.freebsd.org/D15640

Added:
  head/tests/sys/audit/file-write.c   (contents, props changed)
Modified:
  head/tests/sys/audit/Makefile

Modified: head/tests/sys/audit/Makefile
==============================================================================
--- head/tests/sys/audit/Makefile	Fri Jun  1 13:26:45 2018	(r334486)
+++ head/tests/sys/audit/Makefile	Fri Jun  1 16:23:47 2018	(r334487)
@@ -3,10 +3,13 @@
 TESTSDIR=	${TESTSBASE}/sys/audit
 
 ATF_TESTS_C=	file-create
+ATF_TESTS_C+=	file-write
 ATF_TESTS_C+=	file-read
 
 SRCS.file-create+=	file-create.c
 SRCS.file-create+=	utils.c
+SRCS.file-write+=	file-write.c
+SRCS.file-write+=	utils.c
 SRCS.file-read+=	file-read.c
 SRCS.file-read+=	utils.c
 

Added: head/tests/sys/audit/file-write.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/tests/sys/audit/file-write.c	Fri Jun  1 16:23:47 2018	(r334487)
@@ -0,0 +1,139 @@
+/*-
+ * Copyright 2018 Aniket Pandey
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * SUCH DAMAGE.
+ *
+ * $FreeBSD$
+ */
+
+#include <atf-c.h>
+#include <fcntl.h>
+
+#include "utils.h"
+
+static struct pollfd fds[1];
+static mode_t mode = 0777;
+static off_t offlen = 0;
+static const char *path = "fileforaudit";
+static const char *errpath = "dirdoesnotexist/fileforaudit";
+static const char *successreg = "fileforaudit.*return,success";
+static const char *failurereg = "fileforaudit.*return,failure";
+
+
+ATF_TC_WITH_CLEANUP(truncate_success);
+ATF_TC_HEAD(truncate_success, tc)
+{
+	atf_tc_set_md_var(tc, "descr", "Tests the audit of a successful "
+					"truncate(2) call");
+}
+
+ATF_TC_BODY(truncate_success, tc)
+{
+	/* File needs to exist to call truncate(2) */
+	ATF_REQUIRE(open(path, O_CREAT, mode) != -1);
+	FILE *pipefd = setup(fds, "fw");
+	ATF_REQUIRE_EQ(0, truncate(path, offlen));
+	check_audit(fds, successreg, pipefd);
+}
+
+ATF_TC_CLEANUP(truncate_success, tc)
+{
+	cleanup();
+}
+
+
+ATF_TC_WITH_CLEANUP(truncate_failure);
+ATF_TC_HEAD(truncate_failure, tc)
+{
+	atf_tc_set_md_var(tc, "descr", "Tests the audit of an unsuccessful "
+					"truncate(2) call");
+}
+
+ATF_TC_BODY(truncate_failure, tc)
+{
+	FILE *pipefd = setup(fds, "fw");
+	/* Failure reason: file does not exist */
+	ATF_REQUIRE_EQ(-1, truncate(errpath, offlen));
+	check_audit(fds, failurereg, pipefd);
+}
+
+ATF_TC_CLEANUP(truncate_failure, tc)
+{
+	cleanup();
+}
+
+
+ATF_TC_WITH_CLEANUP(ftruncate_success);
+ATF_TC_HEAD(ftruncate_success, tc)
+{
+	atf_tc_set_md_var(tc, "descr", "Tests the audit of a successful "
+					"ftruncate(2) call");
+}
+
+ATF_TC_BODY(ftruncate_success, tc)
+{
+	int filedesc;
+	const char *regex = "ftruncate.*return,success";
+	/* Valid file descriptor needs to exist to call ftruncate(2) */
+	ATF_REQUIRE((filedesc = open(path, O_CREAT | O_RDWR)) != -1);
+	FILE *pipefd = setup(fds, "fw");
+	ATF_REQUIRE_EQ(0, ftruncate(filedesc, offlen));
+	check_audit(fds, regex, pipefd);
+}
+
+ATF_TC_CLEANUP(ftruncate_success, tc)
+{
+	cleanup();
+}
+
+
+ATF_TC_WITH_CLEANUP(ftruncate_failure);
+ATF_TC_HEAD(ftruncate_failure, tc)
+{
+	atf_tc_set_md_var(tc, "descr", "Tests the audit of an unsuccessful "
+					"ftruncate(2) call");
+}
+
+ATF_TC_BODY(ftruncate_failure, tc)
+{
+	const char *regex = "ftruncate.*return,failure";
+	FILE *pipefd = setup(fds, "fw");
+	/* Failure reason: bad file descriptor */
+	ATF_REQUIRE_EQ(-1, ftruncate(-1, offlen));
+	check_audit(fds, regex, pipefd);
+}
+
+ATF_TC_CLEANUP(ftruncate_failure, tc)
+{
+	cleanup();
+}
+
+
+ATF_TP_ADD_TCS(tp)
+{
+	ATF_TP_ADD_TC(tp, truncate_success);
+	ATF_TP_ADD_TC(tp, truncate_failure);
+	ATF_TP_ADD_TC(tp, ftruncate_success);
+	ATF_TP_ADD_TC(tp, ftruncate_failure);
+
+	return (atf_no_error());
+}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201806011623.w51GNlY6008654>