Date: Wed, 5 Aug 2015 20:04:55 -0700 From: "K. Macy" <kmacy@freebsd.org> To: Glen Barber <gjb@freebsd.org> Cc: Pawel Jakub Dawidek <pjd@freebsd.org>, Andriy Gapon <avg@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Xin Li <delphij@delphij.net> Subject: Re: svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <CAHM0Q_OHO6tyx3AyyDpMtD7mYeizpW-cLn68dDmdZhwKaQRCVQ@mail.gmail.com> In-Reply-To: <20150806022247.GG1484@FreeBSD.org> References: <201507020832.t628W3WJ002944@repo.freebsd.org> <CAHM0Q_OcLqT_VuxmL4tFrDyEhAEprm_ivP8j_mrow6ZG1FLcsg@mail.gmail.com> <55BF6A84.1040808@FreeBSD.org> <20150806021723.GB72832@garage.freebsd.pl> <20150806022247.GG1484@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
His proposed solution looks fine to me. Why don't we commit that? -K On Wed, Aug 5, 2015 at 7:22 PM, Glen Barber <gjb@freebsd.org> wrote: > On Thu, Aug 06, 2015 at 04:17:23AM +0200, Pawel Jakub Dawidek wrote: >> On Mon, Aug 03, 2015 at 04:20:04PM +0300, Andriy Gapon wrote: >> > On 30/07/2015 10:24, K. Macy wrote: >> > > Just FYI this change introduces a deadlock with with the >> > > spa_namespace_lock. Mount will be holding this lock while trying to >> > > acquire the spa_namespace_lock. zfskern on the other hand holds the >> > > spa_namespace_lock when calling zfs_freebsd_access which in turn >> > > tries to acquire the teardown lock. >> > >> > I missed the fact that zpool.cache file is being written with spa_namespace_lock >> > held. >> > I'll try to either resolve the problem in the next day or I will revert the change. >> >> FYI, I'm hitting this deadlock on my laptop. Reverting the change fixes >> the problem. >> > > Since it is now 3 days after "I'll try to either resolve the problem in > the next day or I will revert the change", my view is that this needs to > be reverted now, if it hasn't been done already. > > Glen >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHM0Q_OHO6tyx3AyyDpMtD7mYeizpW-cLn68dDmdZhwKaQRCVQ>