Date: Fri, 13 Jan 2017 17:07:43 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: "Conrad E. Meyer" <cem@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Julio Merino <jmmv@freebsd.org> Subject: Re: svn commit: r312103 - head/tests/sys/vfs Message-ID: <73E9CEF8-F9B4-4108-9421-CD8A456BB32D@gmail.com> In-Reply-To: <07802033-D072-404C-8920-3E598C1C567F@gmail.com> References: <201701140103.v0E13K8b068874@repo.freebsd.org> <07802033-D072-404C-8920-3E598C1C567F@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Jan 13, 2017, at 17:06, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > >> >> On Jan 13, 2017, at 17:03, Conrad E. Meyer <cem@FreeBSD.org> wrote: >> >> Author: cem >> Date: Sat Jan 14 01:03:20 2017 >> New Revision: 312103 >> URL: https://svnweb.freebsd.org/changeset/base/312103 >> >> Log: >> Revert r310994 >> >> Don't implement some terrible hack on a test by test basis. The >> framework fix is straightforward and can be chased up in the original >> bug. >> >> Reviewed by: ngie ("be my guest") > > You should have filed an issue with atf/kyua, had the fix done, then done the necessary parts in releasing a new port/package. Please disable the test because it doesn’t work at all right now on CURRENT and it will ping the sh’t out of the jenkins email until fixed. > -Ngie PS Saying “be my guest” isn’t review in any shape or form, nor is it my consent towards your change being implemented now. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYeXnfAAoJEPWDqSZpMIYVWc8P/i185FJjveEFoFytxIDKMQ66 pzAsTqF/F6mYEc7sixFm8TVtrf7I0e2fw+Uy2DMThiZ/rrplD3k9twj68RzVTIFn I2ENq8ZaxLi7vEIBAKz7YnojcK1R8Ag9D8Z7BpBtlVTqVdKHyPqD4/bbDlJ8Du8Q tp6x1/awYzak5sbkS0JlcTiTqTDiX02vckI0tBHFyPv0Sj+6O5hrLCzwA/xgp0yv Peql/vW0xuFwGcYj2XEdUReFkloH8ypmQrw2bD2Yp+o6sVTV1jkXjFkjCEY6hDJj 443fGQquxGHWMEZF4PpPLZh8o5dUVbqFi0pPTL7+xJwJmCyT9MmQFIRemwZm/stO Lxj459OuAoe3YlPemuggLfiBQEW9V+V73Xbx3g3jITPM29GMlxCcf/vSljMwmoPt tFrxBKCj3Cmvi3BB6dOGXQK73Uo7DxwQwr2SbbSDZlQrRt5X/0XLUc4ACQXxzkuX o0KHApRWlyenzwyaKUO8SFruIIEElZgcp0z5ID7yHhYky7tvMVltVX+bGtQY1ofC C6WgYDlRxi7Z5DQqzLWI7aZM52rn5972/3/9TvaSpsUgD3aB/2wiEmKABzO0U+5E 3k1zHsxv7+C3XFoAG66nOUkFzaBhiAitHNL7EuBQ2NQBkzEja0Aw1q2TAhjWu3t+ n4W4lxvGvs4NKcn0VLAe =J65u -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?73E9CEF8-F9B4-4108-9421-CD8A456BB32D>