Date: Tue, 3 Jan 2017 11:15:42 +0000 (UTC) From: jbeich@freebsd.org (Jan Beich) To: ports-committers@freebsd.org, sunpoet@FreeBSD.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r430238 - head/databases/rocksdb Message-ID: <20170103111542.37681315A@freefall.freebsd.org> In-Reply-To: <201701010417.v014HjI0080871@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> writes:
> --- head/databases/rocksdb/Makefile Sun Jan 1 03:57:43 2017 (r430237)
> +++ head/databases/rocksdb/Makefile Sun Jan 1 04:17:45 2017 (r430238)
> @@ -50,10 +50,6 @@ ZSTD_LIB_DEPENDS= libzstd.so:archivers/z
>
> .include <bsd.port.pre.mk>
>
> -.if ${OSVERSION} <= 1000000
> -CFLAGS+= -D_GLIBCXX_USE_C99
> -.endif
> -
This may be premature. The underlying issue is documented in bug 193528
and has only been fixed in lang/gcc6 but not in lang/gcc or lang/gcc5.
Architectures still stuck with base GCC (sparc64, powerpc*, mips*) are
going to be BROKEN. And let's not forget users that prefer GCC over
Clang for various reasons e.g., -Og, -flto, -fopenmp on i386, Graphite.
$ uname -rp
12.0-CURRENT amd64
$ pkg install -qy gcc
$ make clean all CC=gcc49 CXX=g++49 CPP=cpp49
[...]
util/options_helper.cc: In function 'uint64_t rocksdb::ParseUint64(const string&)':
util/options_helper.cc:260:18: error: 'stoull' is not a member of 'std'
uint64_t num = std::stoull(value.c_str(), &endchar);
^
util/options_helper.cc: In function 'int rocksdb::{anonymous}::ParseInt(const string&)':
util/options_helper.cc:378:13: error: 'stoi' is not a member of 'std'
int num = std::stoi(value.c_str(), &endchar);
^
util/options_helper.cc: In function 'double rocksdb::{anonymous}::ParseDouble(const string&)':
util/options_helper.cc:416:10: error: 'stod' is not a member of 'std'
return std::stod(value);
^
util/options_helper.cc:420:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170103111542.37681315A>