Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Apr 2002 23:36:00 +0300
From:      Ruslan Ermilov <ru@FreeBSD.org>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        re@FreeBSD.org, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject:   Re: cvs commit: src Makefile Makefile.inc1 src/etc Makefile src/
Message-ID:  <20020426203600.GA69757@sunbay.com>
In-Reply-To: <XFMail.20020426161727.jhb@FreeBSD.org>
References:  <200204261755.g3QHtRv72264@freefall.freebsd.org> <XFMail.20020426161727.jhb@FreeBSD.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On Fri, Apr 26, 2002 at 04:17:27PM -0400, John Baldwin wrote:
> 
> On 26-Apr-2002 Ruslan Ermilov wrote:
> >   Log:
> >   Milestone #1 in cross-arch make releases.
> 
> I'm sure re@ or qa@ would have loved to have had a chance to review this before
> it went in.
> 
Huh?  My initial message subjected "Cross-platform releases" was CC:'ed
to re@FreeBSD as well.  None from re@ replied to my message.  Is it
probably a good time for me to apply to join re@?  :-)

> >   In release.3 and doMFSKERN, build kernels in the "world"
> >   environment.  KERNELS now means "additional" kernels, GENERIC is
> >   always built.
> 
> This is wrong.  Not everyone wants to use GENERIC.  Instead, please use
> the approach of a patch green has worked up that replaces KERNELS with two
> variables:
> 
> DEFAULTKERNEL?= GENERIC
> #EXTRAKERNELS?=
> 
> Where DEFAULTKERNEL is always built and is installed as /boot/kernel/kernel
> on CD's, and in the base dist, etc.  EXTRAKERNELS is an optional list similar
> to what you have done with KERNELS.  We should not specifically tie people to
> using GENERIC as the default kernel.  For people who build custom releases, it
> should be possible to use a different kernel config besides GENERIC for the
> default kernel install, yet still include a GENERIC kernel in the release as a
> fall-back kernel.
> 
Probably, but my patch did not make things worse.  Old version (before my
patch) assumed that GENERIC was always present in KERNELS, and used it as
the _main_ kernel:

:	# Install a standard boot kernel+modules
:	mkdir -p ${RD}/trees/base/boot/kernel
:	cp -Rp ${RD}/kernels/GENERIC/* ${RD}/trees/base/boot/kernel
	                     ^^^^^^^
:	touch release.3

> >   Inline createBOOTMFS target.
> 
> Why?
>  
Because it's now used only once.  I think that calling it in doMFSKERN
in the old version was an oversight too.

> >   Use already built GENERIC kernel modules to augment mfsfd's
> >   /stand/modules.  GC doMODULES as such.
> 
> This assumes too much about GENERIC, IMO.  Eventually we might use a separate
> kernel config that just builds modules and no actual kernel for this type of
> stuff.
> 
The only assumption made is that _all_ modules are built with GENERIC.
This is always true unless MODULES_OVERRIDE is set (which it apparently
is not).  Moreover, BOOTMFS (for which we create modules) is by design
a reduced version of GENERIC.


Cheers,
-- 
Ruslan Ermilov		Sysadmin and DBA,
ru@sunbay.com		Sunbay Software AG,
ru@FreeBSD.org		FreeBSD committer,
+380.652.512.251	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org

iD8DBQE8ybowUkv4P6juNwoRAl0FAJ0eA+azVxV7qheWPKBWQZEAWOx8NACghQUP
AcjESAtuJ/szb7t23+TE108=
=POlc
-----END PGP SIGNATURE-----
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020426203600.GA69757>