Date: Fri, 24 Apr 2020 07:55:39 +0000 (UTC) From: Andriy Gapon <avg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r360242 - head/sys/dev/iicbus Message-ID: <202004240755.03O7tdmq072415@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: avg Date: Fri Apr 24 07:55:39 2020 New Revision: 360242 URL: https://svnweb.freebsd.org/changeset/base/360242 Log: acpi_iicbus: set device description in the probe method Kernel prints the device announcement before the attach method is called, so if the correct description is not set by the probe method, then the announcement would have an incorrect one. MFC after: 1 week Modified: head/sys/dev/iicbus/acpi_iicbus.c Modified: head/sys/dev/iicbus/acpi_iicbus.c ============================================================================== --- head/sys/dev/iicbus/acpi_iicbus.c Fri Apr 24 07:49:21 2020 (r360241) +++ head/sys/dev/iicbus/acpi_iicbus.c Fri Apr 24 07:55:39 2020 (r360242) @@ -573,6 +573,7 @@ acpi_iicbus_probe(device_t dev) if (handle == NULL) return (ENXIO); + device_set_desc(dev, "Philips I2C bus (ACPI-hinted)"); return (BUS_PROBE_DEFAULT); } @@ -581,8 +582,6 @@ acpi_iicbus_attach(device_t dev) { struct acpi_iicbus_softc *sc = device_get_softc(dev); int error; - - device_set_desc(dev, "Philips I2C bus (ACPI-hinted)"); if (ACPI_FAILURE(acpi_iicbus_enumerate_children(dev))) device_printf(dev, "children enumeration failed\n");
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202004240755.03O7tdmq072415>