Date: Sun, 2 Dec 2007 01:04:48 GMT From: Hans Petter Selasky <hselasky@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 129940 for review Message-ID: <200712020104.lB214mCb021751@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=129940 Change 129940 by hselasky@hselasky_laptop001 on 2007/12/02 01:04:07 "usbd_set_frame_data()" does no longer set the length, only the buffer pointer. The USB P4 project should compile again after this. Affected files ... .. //depot/projects/usb/src/sys/dev/usb/usb_subr.h#63 edit .. //depot/projects/usb/src/sys/dev/usb/usb_transfer.c#56 edit Differences ... ==== //depot/projects/usb/src/sys/dev/usb/usb_subr.h#63 (text+ko) ==== @@ -764,7 +764,7 @@ void usbd_transfer_start(struct usbd_xfer *xfer); void usbd_transfer_stop(struct usbd_xfer *xfer); void usbd_transfer_drain(struct usbd_xfer *xfer); -void usbd_set_frame_data(struct usbd_xfer *xfer, void *ptr, uint32_t len, uint32_t frindex); +void usbd_set_frame_data(struct usbd_xfer *xfer, void *ptr, uint32_t frindex); void usbd_set_frame_offset(struct usbd_xfer *xfer, uint32_t offset, uint32_t frindex); void usbd_callback_wrapper(struct usbd_xfer *xfer); void usbd_do_callback(struct usbd_xfer **pp_xfer, struct thread *td); ==== //depot/projects/usb/src/sys/dev/usb/usb_transfer.c#56 (text+ko) ==== @@ -1893,18 +1893,16 @@ /*------------------------------------------------------------------------* * usbd_set_frame_data * - * This function sets the pointer and length of data that should + * This function sets the pointer of the buffer that should * loaded directly into DMA for the given USB frame. Passing "ptr" - * equal to NULL while "len" is greater than zero gives undefined - * results! + * equal to NULL while the corresponding "frlength" is greater + * than zero gives undefined results! *------------------------------------------------------------------------*/ void -usbd_set_frame_data(struct usbd_xfer *xfer, void *ptr, uint32_t len, - uint32_t frindex) +usbd_set_frame_data(struct usbd_xfer *xfer, void *ptr, uint32_t frindex) { /* set virtual address to load and length */ xfer->frbuffers[frindex].buffer = ptr; - xfer->frlengths[frindex] = len; return; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712020104.lB214mCb021751>