Date: Wed, 01 Nov 2017 11:48:54 +0100 From: "Herbert J. Skuhra" <herbert@mailbox.org> To: Mariusz Zaborski <oshogbo@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r325062 - in head/lib: . libcasper libcasper/libcasper libcasper/services libcasper/services/cap_dns libcasper/services/cap_dns/tests libcasper/services/cap_grp libcasper/services/cap_g... Message-ID: <87h8uexoix.wl-herbert@mailbox.org> In-Reply-To: <201710281923.v9SJNvE5021346@repo.freebsd.org> References: <201710281923.v9SJNvE5021346@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 28 Oct 2017 21:23:57 +0200, Mariusz Zaborski <oshogbo@FreeBSD.org> wrote: > > Author: oshogbo > Date: Sat Oct 28 19:23:57 2017 > New Revision: 325062 > URL: https://svnweb.freebsd.org/changeset/base/325062 > > Log: > Introduce caspermocks. > > The idea behinds mocks is that we don't need to ifdef a lot of code in > tools itself but those defines are hidden in the casper library. > Right now the mocks are implemented as define/inlines functions. > There was a very long discussion how this should be implemented. > This approach has some advantages like we don't need to link to any additional > libraries. Unfortunately there are also some disadvantages for example it is > easy to get library out of sync between two versions of functions or that we > need extra define to compile program with casper support. > This isn't an ideal solution but it's good enough for now and should simplify > capsicumizing programs. This also doesn't close us any other ways to do those > mocks and this should evolve in time. > > Discussed with: pjd, emaste, ed, rwatson, bapt, cem, bdrewery > Differential Revision: https://reviews.freebsd.org/D8753 Again, after this commit libcasper.so.0 is installed to /usr/lib and not /lib: % ls -l /usr/lib/libcasper.so* lrwxr-xr-x 1 root wheel 14 Oct 29 10:51 /usr/lib/libcasper.so -> libcasper.so.0 -r--r--r-- 1 root wheel 22424 Oct 29 10:51 /usr/lib/libcasper.so.0 But usr/lib/libcasper.so.0 is listed in ObsoleteFiles.inc: % grep -B 2 libcasper.so /usr/src/ObsoleteFiles.inc # 20131202: libcapsicum and libcasper moved to /lib/ OLD_LIBS+=usr/lib/libcapsicum.so.0 OLD_LIBS+=usr/lib/libcasper.so.0 Thanks. -- Herbert
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87h8uexoix.wl-herbert>