Date: Fri, 11 May 2012 12:54:16 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: freebsd-hackers@FreeBSD.org, Takahashi Yoshihiro <nyan@FreeBSD.org> Subject: Re: bootargs.h Message-ID: <4FACE1C8.4080802@FreeBSD.org> In-Reply-To: <4FABDC23.2090400@FreeBSD.org> References: <4F8999D2.1080902@FreeBSD.org> <201205070953.04032.jhb@freebsd.org> <4FA7E069.8020208@FreeBSD.org> <201205071343.45955.jhb@freebsd.org> <4FA8C7E3.8070006@FreeBSD.org> <4FA92A88.2030000@FreeBSD.org> <4FA96747.3060106@FreeBSD.org> <4FAA3994.2070701@FreeBSD.org> <4FAA54C1.20203@FreeBSD.org> <4FAB8D31.8050301@FreeBSD.org> <4FABDC23.2090400@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
on 10/05/2012 18:17 John Baldwin said the following: > On 5/10/12 5:41 AM, Andriy Gapon wrote: >> on 09/05/2012 14:28 John Baldwin said the following: >>> On 5/9/12 5:32 AM, Andriy Gapon wrote: >>>> >>>> Here is a subversion diff to make use of the new bootargs.h header in pc98 >>>> cdboot and loader, and i386 cdboot and pxeldr: >>>> http://people.freebsd.org/~avg/bootargs.diff >>>> Could you please review it? >>>> Thank you! >>> >>> Looks good. >>> >>>> MFi386 of BTX changes for support of KARGS_FLAGS_EXTARG is pending. >>>> Do you think that it should be done? >>> >>> You mean to pc98's btxldr? I think so, in general we should keep the >>> pc98 BTX bits as close to i386 as possible. >>> >> >> Yes. Here is a complete pc98 patch for bootargs.h and btxldr: >> http://people.freebsd.org/~avg/pc98-btxldr.diff > > Looks ok to me. We should really see about letting PC98 share more code > here rather than using copies if it's not too ugly. > btxcsu.S is the only one that is almost identical between i386 and pc98. I think that it was completely identical and I accidentally broke that. Should fix. btxldr.S and btx.S would require a fair number of ifdefs to be shareable. cdboot.S seems to have too many differences. I am not sure whether and what it would make sense to share. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FACE1C8.4080802>