Date: Fri, 03 Dec 2010 20:12:25 +0200 From: Andriy Gapon <avg@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bruce Cran <brucec@freebsd.org> Subject: Re: svn commit: r216143 - in head: share/man/man9 sys/amd64/include sys/arm/include sys/i386/include sys/ia64/include sys/mips/include sys/pc98/include sys/powerpc/include sys/sparc64/include sys/sun4v... Message-ID: <4CF93309.4050009@freebsd.org> In-Reply-To: <20101204045754.T4046@besplex.bde.org> References: <201012030709.oB379NOH058721@svn.freebsd.org> <20101204045754.T4046@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
on 03/12/2010 20:01 Bruce Evans said the following:
> On Fri, 3 Dec 2010, Bruce Cran wrote:
>
>> Log:
>> Revert r216134. This checkin broke platforms where bus_space are macros:
>> they need to be a single statement, and do { } while (0) doesn't work in this
>> situation so revert until a solution can be devised.
>
> Surprising that do-while doesn't work.
I think GCC extension that allows to put statements inside expressions could help
here:
http://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html#Statement-Exprs
I think that we already use the extension in some places.
--
Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CF93309.4050009>