Date: Fri, 13 Nov 2015 12:39:44 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: "Alexander V. Chernikov" <melifaro@freebsd.org>, Randall Stewart <rrs@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, imp@freebsd.org Subject: Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys Message-ID: <56464A90.2040405@FreeBSD.org> In-Reply-To: <1660421447413365@web19h.yandex.ru> References: <201511101449.tAAEnXIi065747@repo.freebsd.org> <1660421447413365@web19h.yandex.ru>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 11/13/2015 3:16 AM, Alexander V. Chernikov wrote: > 10.11.2015, 17:49, "Randall Stewart" <rrs@FreeBSD.org>: >> Author: rrs >> Date: Tue Nov 10 14:49:32 2015 >> New Revision: 290664 >> URL: https://svnweb.freebsd.org/changeset/base/290664 >> >> Log: >> Add new async_drain to the callout system. This is so-far not used but >> should be used by TCP for sure in its cleanup of the IN-PCB (will be coming shortly). > > Randall, this commit introduced change in callout_stop() which was not mentioned in commit message. > This change has broken lltable arp/nd handling: deleting interface address causes immediate panic. > I also see other other code/subsystems relying on callout_stop() return value (netgraph, pfsync, iscsi). > I was not able to find any discussion/analysis/testing for these in D4076 so this change does not look like being properly tested prior commiting.. > > Fixing this is pretty easy. Keeping _callout_stop_safe() as a function wrapper around a new _callstop_stop_safe_drain() that takes the new argument. Then change callout_stop define to use _callstop_stop_safe_drain(). New code will avoid the wrapper function as it is recompiled. -- Regards, Bryan Drewery [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWRkqQAAoJEDXXcbtuRpfP2MgH/Rsb4k6DoC+2RpUWM18GiuB5 YXoWqzhOguIJ3pYfujBT1rddw2s7J31ZB+Q3RhMJUoBadqEilFUGK1Pr73U3TZeP nmXLwi+X3ETal25nb0MmPVlm2NLuW1NdBNxrmxb5dJxIdUEeEWTLApV+yjE1NdaX i9BQEnYGbxk6yzVxHeRj79fNchTkpBX1woHlI4yXTRLn9OOrvIAh8No5OlDK1mCp oGGn3cAbTZjhr+RFUPTas4swfEh4I33HCOvQMbmdJixvHC1l3E1pQWMxFYN0fWdr KhuBfomzcF2mP3lRNEweE47tg6+iIGUKwgeGhYiJf7arImA5tT9BC8sbgzj4gHE= =0Pmp -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56464A90.2040405>