Date: Thu, 20 Dec 2001 15:50:11 -0700 From: Nate Williams <nate@yogotech.com> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Bruce Evans <bde@zeta.org.au>, Peter Wemm <peter@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha pmap.c src/sys/i386/i386 pmap.c src/sys/ia64/ia64 pmap.c Message-ID: <15394.27427.220607.984244@caddis.yogotech.com> In-Reply-To: <667.1008876572@critter.freebsd.dk> References: <20011221005726.Q884-100000@gamplex.bde.org> <667.1008876572@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
> >> peter 2001/12/19 21:29:59 PST
> >>
> >> Modified files:
> >> sys/alpha/alpha pmap.c
> >> sys/i386/i386 pmap.c
> >> sys/ia64/ia64 pmap.c
> >> Log:
> >> Replace a bunch of:
> >> for (pv = TAILQ_FIRST(&m->md.pv_list);
> >> pv;
> >> pv = TAILQ_NEXT(pv, pv_list)) {
> >> with:
> >> TAILQ_FOREACH(pv, &m->md.pv_list, pv_list) {
> >>
> >> Revision Changes Path
> >> 1.79 +9 -28 src/sys/alpha/alpha/pmap.c
> >> 1.301 +6 -20 src/sys/i386/i386/pmap.c
> >> 1.41 +10 -30 src/sys/ia64/ia64/pmap.c
> >
> >This is a regression IMO. Please write C programs in something
> >resembling C.
>
> This is an improvement IMO. Please use whatever means we have to
> improve readability of our source code.
I agree with Bruce. It reduces readability because it requires
implicit knowledge of the (IMHO) incredibly confusing QUEUE macros.
The original code is more C-like, and is easier to understand.
Nate
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15394.27427.220607.984244>