Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 9 Oct 2010 08:37:19 +1100 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Peter Holm <pho@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r213568 - head/sys/boot/i386/gptboot
Message-ID:  <20101009082104.X1487@besplex.bde.org>
In-Reply-To: <201010081027.o98ARrUQ087673@svn.freebsd.org>
References:  <201010081027.o98ARrUQ087673@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 8 Oct 2010, Peter Holm wrote:

> Log:
>  Ensure that a make from sys/boot does not pick up include files from
>  /usr/include.
>
>  Discussed with:	 kib
>
> Modified:
>  head/sys/boot/i386/gptboot/Makefile
>
> Modified: head/sys/boot/i386/gptboot/Makefile
> ==============================================================================
> --- head/sys/boot/i386/gptboot/Makefile	Fri Oct  8 09:43:06 2010	(r213567)
> +++ head/sys/boot/i386/gptboot/Makefile	Fri Oct  8 10:27:52 2010	(r213568)
> @@ -36,6 +36,7 @@ CFLAGS=	-DBOOTPROG=\"gptboot\" \
> 	-I${.CURDIR}/../common \
> 	-I${.CURDIR}/../btx/lib -I. \
> 	-I${.CURDIR}/../boot2 \
> +	-I${.CURDIR}/../../.. \
> 	-Wall -Waggregate-return -Wbad-function-cast -Wcast-align \
> 	-Wmissing-declarations -Wmissing-prototypes -Wnested-externs \
> 	-Wpointer-arith -Wshadow -Wstrict-prototypes -Wwrite-strings \
>

This should be handled by setting -nostdinc in the top-level Makefile.inc,
as was done in 1998 or earlier by sys/i386/boot/Makefile.inc (the
sys/boot hierarchy is still of amazingly lower quality than the
sys/i386/boot hierarchy), or in a central foo.mk Makefile as is done
for kernels and modules.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101009082104.X1487>