Date: Mon, 15 Jan 2024 10:02:17 -0700 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: df834e06bbc7 - main - git-arc: Just strip escape sequences form arc log Message-ID: <CANCZdfqdv-e7UsWEV99p0hLuxesPpmOyfs4WyJ9QekiaVzc=ew@mail.gmail.com> In-Reply-To: <CANCZdfoNWuX%2BG6gTjGPRugyCxNkGH=wZ1kUF4z93mEQ1qmXxmw@mail.gmail.com> References: <202401150224.40F2OSBS093537@gitrepo.freebsd.org> <de314243-7cac-4f1c-b013-5c6c8cadd0bc@FreeBSD.org> <CANCZdfoNWuX%2BG6gTjGPRugyCxNkGH=wZ1kUF4z93mEQ1qmXxmw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000091d0f6060efefa28 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hey John, On Mon, Jan 15, 2024 at 9:37=E2=80=AFAM Warner Losh <imp@bsdimp.com> wrote: > > > On Mon, Jan 15, 2024 at 9:30=E2=80=AFAM John Baldwin <jhb@freebsd.org> wr= ote: > >> On 1/14/24 6:24 PM, Warner Losh wrote: >> > The branch main has been updated by imp: >> > >> > URL: >> https://cgit.FreeBSD.org/src/commit/?id=3Ddf834e06bbc78c03cb6b35f074ae43= 673c9ce463 >> > >> > commit df834e06bbc78c03cb6b35f074ae43673c9ce463 >> > Author: Warner Losh <imp@FreeBSD.org> >> > AuthorDate: 2024-01-15 02:22:04 +0000 >> > Commit: Warner Losh <imp@FreeBSD.org> >> > CommitDate: 2024-01-15 02:23:45 +0000 >> > >> > git-arc: Just strip escape sequences form arc log >> > >> > Just strip escape sequences and Warning: lines from 'arc list' >> output. I >> > upgraded and they changed and git arc list broke. This restores i= ts >> > functionality. >> > >> > Note: jhb didn't like this, so if others object, I'll fix... >> > >> > Sponsored by: Netflix >> > Reviewed by: markj >> > Differential Revision: https://reviews.freebsd.org/D36553 >> >> Namely, it breaks the color output for reviews in different states, so >> Needs Review >> shows up as purple, Approved as green, etc. If you find the color outpu= t >> useful >> you'll have to revert this locally. >> >> Also, your last update in the review said that git arc was no longer >> broken for you >> back in May implying this commit wasn't needed for git arc to work for >> you? >> > > Yes and no. I was mistaken. This change is still needed, but its scope ca= n > be reduced. > The trouble is that it's at the first for the other things I committed an= d > getting it out of the > way was a pain (I tried). Since I didn't want to delay things any further= , > I went ahead and > committed and thought I'd fix stuff if there were objections.I'll do that > now. > So even w/o my change, I don't see the color output for the review states (so I can remove the general filter I added for color). That's easy enough. but what are you doing to get color in the current setup? Or is your arcanist install old and un-updated? That is, even w/o git-arc.sh, I see color for 'arc list' but not for 'arc list | more'. I'd kinda like to test things with and without the change, though. I'll prep a commit that just drops the ANSI-color filter, but if arc list no longer does that for pipes it won't change anything (I think that was the change that I was talking about back in May). Warner --00000000000091d0f6060efefa28 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">Hey John,<br></div><br><div class=3D"gmai= l_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jan 15, 2024 at 9:37= =E2=80=AFAM Warner Losh <<a href=3D"mailto:imp@bsdimp.com">imp@bsdimp.co= m</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin= :0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"= ><div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote"= ><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jan 15, 2024 at 9:30=E2=80= =AFAM John Baldwin <<a href=3D"mailto:jhb@freebsd.org" target=3D"_blank"= >jhb@freebsd.org</a>> wrote:<br></div><blockquote class=3D"gmail_quote" = style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pa= dding-left:1ex">On 1/14/24 6:24 PM, Warner Losh wrote:<br> > The branch main has been updated by imp:<br> > <br> > URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3Ddf834e06bbc7= 8c03cb6b35f074ae43673c9ce463" rel=3D"noreferrer" target=3D"_blank">https://= cgit.FreeBSD.org/src/commit/?id=3Ddf834e06bbc78c03cb6b35f074ae43673c9ce463<= /a><br> > <br> > commit df834e06bbc78c03cb6b35f074ae43673c9ce463<br> > Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org><br> > AuthorDate: 2024-01-15 02:22:04 +0000<br> > Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2024-01-15 02:23:45 +0000<br> > <br> >=C2=A0 =C2=A0 =C2=A0 git-arc: Just strip escape sequences form arc log<= br> >=C2=A0 =C2=A0 =C2=A0 <br> >=C2=A0 =C2=A0 =C2=A0 Just strip escape sequences and Warning: lines fro= m 'arc list' output. I<br> >=C2=A0 =C2=A0 =C2=A0 upgraded and they changed and git arc list broke. = This restores its<br> >=C2=A0 =C2=A0 =C2=A0 functionality.<br> >=C2=A0 =C2=A0 =C2=A0 <br> >=C2=A0 =C2=A0 =C2=A0 Note: jhb didn't like this, so if others objec= t, I'll fix...<br> >=C2=A0 =C2=A0 =C2=A0 <br> >=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0Netflix<br> >=C2=A0 =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 markj<br> >=C2=A0 =C2=A0 =C2=A0 Differential Revision:=C2=A0 <a href=3D"https://re= views.freebsd.org/D36553" rel=3D"noreferrer" target=3D"_blank">https://revi= ews.freebsd.org/D36553</a><br> <br> Namely, it breaks the color output for reviews in different states, so Need= s Review<br> shows up as purple, Approved as green, etc.=C2=A0 If you find the color out= put useful<br> you'll have to revert this locally.<br> <br> Also, your last update in the review said that git arc was no longer broken= for you<br> back in May implying this commit wasn't needed for git arc to work for = you?<br></blockquote><div><br></div><div>Yes and no. I was mistaken. This c= hange is still needed, but its scope can be reduced.</div><div>The trouble = is that it's at the first for the other things I committed and getting = it out of the</div><div>way was a pain (I tried). Since I didn't want t= o delay things any further, I went ahead and</div><div>committed and though= t I'd fix stuff if there were objections.I'll do that now.</div></d= iv></div></blockquote><div><br></div><div>So even w/o my change, I don'= t see the color output for the review states (so I can remove the</div><div= >general filter I added for color). That's easy enough. but what are yo= u doing to get color in the</div><div>current setup? Or is your arcanist in= stall old and un-updated?</div><div><br></div><div>That is, even w/o git-ar= c.sh, I see color for 'arc list' but not for 'arc list | more&#= 39;. I'd kinda like to test</div><div>things with and without the chang= e, though.</div><div><br></div><div>I'll prep a commit that just drops = the ANSI-color filter, but if arc list no longer does that for pipes</div><= div>it won't change anything (I think that was the change that I was ta= lking about back in May).</div><div><br></div><div>Warner<br></div></div></= div> --00000000000091d0f6060efefa28--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqdv-e7UsWEV99p0hLuxesPpmOyfs4WyJ9QekiaVzc=ew>