Date: Thu, 16 Jan 2003 00:57:08 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: mike@FreeBSD.org Cc: johan@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdlib realpath.3 realpath.c src/bin/realpath realpath.c Message-ID: <20030116.005708.96919189.imp@bsdimp.com> In-Reply-To: <20030115183943.D58850@espresso.q9media.com> References: <200301152122.h0FLMtdE034299@repoman.freebsd.org> <20030115183943.D58850@espresso.q9media.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20030115183943.D58850@espresso.q9media.com>
Mike Barcroft <mike@FreeBSD.org> writes:
: Johan Karlsson <johan@FreeBSD.org> writes:
: > johan 2003/01/15 13:22:55 PST
: >
: > Modified files:
: > lib/libc/stdlib realpath.3 realpath.c
: > bin/realpath realpath.c
: > Log:
: > realpath(3) should use PATH_MAX instead of MAXPATHLEN according to POSIX.
: >
: > This also reverts the PATH_MAX -> MAXPATHLEN part of
: > rev 1.3 of src/bin/realpath/realpath.c
: >
: > Requested by: imp
: > Reviewed by: imp, bde
: >
: > Revision Changes Path
: > 1.5 +1 -1 src/bin/realpath/realpath.c
: > 1.12 +2 -2 src/lib/libc/stdlib/realpath.3
: > 1.12 +7 -7 src/lib/libc/stdlib/realpath.c
:
: Hmm, I thought it was more complicated than this. IIRC, PATH_MAX
: isn't necessarily available at compile-time, so it needs more
: complications to conform to POSIX in the case where PATH_MAX isn't
: defined. Portablility might not be important, in which case it
: isn't clear why we would change from MAXPATHLEN to PATH_MAX or vice
: versa.
I made this change because PATH_MAX is more posixly correct than
MAXPATHLEN and has a better definition. It only handles the case
where PATH_MAX is a compile time constant, or when you are using gcc
extensions that allow one to allocate memory on the fly.
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030116.005708.96919189.imp>