Date: Fri, 22 Mar 2024 13:31:41 -0300 From: Mitchell Horne <mhorne@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org>, =?UTF-8?Q?Bojan_Novkovi=C4=87?= <bnovkov@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: c21bc6f3c242 - main - ddb: Add CTF-based pretty printing Message-ID: <555d3b44-8193-473e-ba68-5b37aff43a37@freebsd.org> In-Reply-To: <xzqmsp2nr5owbnwed7pfnuxnoj3s5vdlh5nfvmgs6xjx67l2bm@2exh6uoya46q> References: <202403220356.42M3uJh3021416@gitrepo.freebsd.org> <xzqmsp2nr5owbnwed7pfnuxnoj3s5vdlh5nfvmgs6xjx67l2bm@2exh6uoya46q>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/22/24 04:38, Baptiste Daroussin wrote: > On Fri 22 Mar 03:56, Bojan Novković wrote: >> The branch main has been updated by bnovkov: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=c21bc6f3c2425de74141bfee07b609bf65b5a6b3 >> >> commit c21bc6f3c2425de74141bfee07b609bf65b5a6b3 >> Author: Bojan Novković <bnovkov@FreeBSD.org> >> AuthorDate: 2024-03-22 03:01:34 +0000 >> Commit: Bojan Novković <bnovkov@FreeBSD.org> >> CommitDate: 2024-03-22 03:03:33 +0000 >> >> ddb: Add CTF-based pretty printing >> >> Add basic CTF support and a CTF-powered pretty-printer to ddb. >> >> The db_ctf.* files expose a basic interface for fetching type >> data for ELF symbols, interacting with the CTF string table, >> and translating type identifiers to type data. >> >> The db_pprint.c file uses those interfaces to implement >> a pretty-printer for all kernel ELF symbols. >> The pretty-printer works with symbol names and arbitrary addresses: >> pprint struct thread 0xffffffff8194ad90 >> >> Pretty-printing currently only works after the root filesystem >> gets mounted because the CTF info is not available during >> early boot. >> >> Differential Revision: https://reviews.freebsd.org/D37899 >> Approved by: markj (mentor) > > This breaks building kernel MINIMAL > > ld: error: undefined symbol: db_ctf_lookup_typename > > Best regards, > Bapt This should be addressed by dc7ae2bc6fadd. Bojan, please have a look to ensure that it was done correctly. Cheers, Mitchell
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?555d3b44-8193-473e-ba68-5b37aff43a37>