Date: Thu, 3 Apr 2003 07:59:17 -0800 From: "David O'Brien" <obrien@FreeBSD.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: Marcel Moolenaar <marcel@xcllnt.net> Subject: Re: cvs commit: src/libexec/talkd announce.c extern.h print.c table.c talkd.c Message-ID: <20030403155917.GC17860@dragon.nuxi.com> In-Reply-To: <20030403085350.GA37174@sunbay.com> References: <200304030513.h335DR60079544@repoman.freebsd.org> <20030402231638.A81523@FreeBSD.org> <20030403055049.GA67232@dhcp01.pn.xcllnt.net> <20030403180026.A29934@gamplex.bde.org> <20030403085350.GA37174@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 03, 2003 at 11:53:50AM +0300, Ruslan Ermilov wrote:
> -. if ${WARNS} > 4
> +. if ${WARNS} > 4 && !empty(CFLAGS:M-O*) && empty(CFLAGS:M-O0)
> CFLAGS += -Wuninitialized
> . endif
Why not just get rid of it totally? We have this already:
. if ${WARNS} > 1 && ${WARNS} < 5
# XXX Delete -Wuninitialized by default for now -- the compiler doesn't
# XXX always get it right.
CFLAGS += -Wno-uninitialized
. endif
so we already know it is problematic. OR rather than use:
. if ${WARNS} > 4
CFLAGS += -Wuninitialized
. endif
use
. if ${WARNS} == 4
CFLAGS += -Wuninitialized
. endif
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030403155917.GC17860>