Date: Fri, 13 Nov 2015 12:48:58 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: "Alexander V. Chernikov" <melifaro@freebsd.org>, Randall Stewart <rrs@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, imp@freebsd.org Subject: Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys Message-ID: <56464CBA.7060206@FreeBSD.org> In-Reply-To: <56464A90.2040405@FreeBSD.org> References: <201511101449.tAAEnXIi065747@repo.freebsd.org> <1660421447413365@web19h.yandex.ru> <56464A90.2040405@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --O57Uc3KRGFjE9H7grtNpeAIcE7THREfU6 Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: quoted-printable On 11/13/2015 12:39 PM, Bryan Drewery wrote: > On 11/13/2015 3:16 AM, Alexander V. Chernikov wrote: >> 10.11.2015, 17:49, "Randall Stewart" <rrs@FreeBSD.org>: >>> Author: rrs >>> Date: Tue Nov 10 14:49:32 2015 >>> New Revision: 290664 >>> URL: https://svnweb.freebsd.org/changeset/base/290664 >>> >>> Log: >>> Add new async_drain to the callout system. This is so-far not used = but >>> should be used by TCP for sure in its cleanup of the IN-PCB (will b= e coming shortly). >> >> Randall, this commit introduced change in callout_stop() which was not= mentioned in commit message. >> This change has broken lltable arp/nd handling: deleting interface add= ress causes immediate panic. >> I also see other other code/subsystems relying on callout_stop() retur= n value (netgraph, pfsync, iscsi). >> I was not able to find any discussion/analysis/testing for these in D4= 076 so this change does not look like being properly tested prior commiti= ng.. >> >> >=20 > Fixing this is pretty easy. Keeping _callout_stop_safe() as a function > wrapper around a new _callstop_stop_safe_drain() that takes the new > argument. Then change callout_stop define to use > _callstop_stop_safe_drain(). New code will avoid the wrapper function a= s > it is recompiled. >=20 I was more speaking about hps@ point that the drain ptr is random for old modules. This should fix that: https://people.freebsd.org/~bdrewery/patches/callout-abi-compat.diff I don't have any opinion or idea on the return value though. Perhaps a revert is best for now until it can be discussed properly. --=20 Regards, Bryan Drewery --O57Uc3KRGFjE9H7grtNpeAIcE7THREfU6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWRky6AAoJEDXXcbtuRpfPjTMIALeH8hd6JTFTGFQVt9q+ylgD k13e9qi+SNUeCZMs+6+5u4KgwpN7qzndd1fZQg9ovmxmmQq4DAzLBDLDutaHLVl0 kcyo4OUlpCVjH/RohAQEe6b9A7rkxjduJDLlgwZvx5o2ww0rMPb+znjHnY52WN3D kxo4wEb+QKvwzbXPCaZCNyYZ9IF9Ik710yeFiqxZvOyVGoN2zlr2mlkgmtc3C+oM ulMpI2lcywZEJsddhA24f8Aks8Cuy+IMscxi8F//soIL62lrOEM5KT909NA6JXNf W3SFjhnXeQi/wqhjwBqE49h23SR0bubjAWtW9vOGyNCFPRs4WKu1va6jrCmk+cU= =bw+E -----END PGP SIGNATURE----- --O57Uc3KRGFjE9H7grtNpeAIcE7THREfU6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56464CBA.7060206>