Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 2 Feb 2010 20:51:35 +0000 (UTC)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r203403 - projects/capabilities8/libexec/rtld-elf
Message-ID:  <201002022051.o12KpZC6073825@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: rwatson
Date: Tue Feb  2 20:51:35 2010
New Revision: 203403
URL: http://svn.freebsd.org/changeset/base/203403

Log:
  Merge c174171 from the p4 TrustedBSD Capabilities branch to capabilities8:
  
    Process LD_BINARY in rtld-elf-cap rather than using a hard-coded
    descriptor number; this is already set in libcapsicum but we weren't
    using it.
  
  Sponsored by:	Google, Inc.

Modified:
  projects/capabilities8/libexec/rtld-elf/rtld.c

Modified: projects/capabilities8/libexec/rtld-elf/rtld.c
==============================================================================
--- projects/capabilities8/libexec/rtld-elf/rtld.c	Tue Feb  2 20:49:48 2010	(r203402)
+++ projects/capabilities8/libexec/rtld-elf/rtld.c	Tue Feb  2 20:51:35 2010	(r203403)
@@ -395,6 +395,11 @@ _rtld(Elf_Addr *sp, func_ptr_type *exit_
     assert(aux_info[AT_BASE] != NULL);
     init_rtld((caddr_t) aux_info[AT_BASE]->a_un.a_ptr);
 
+    /* XXXRW: Need to do something about program names in capability mode. */
+    __progname = obj_rtld.path; /* TODO: binary name */
+    argv0 = argv[0] != NULL ? argv[0] : "(null)";
+    environ = env;
+
 #ifdef IN_RTLD_CAP
     /*
      * In capability mode, the kernel has executed ld-elf-cap.so directly,
@@ -404,23 +409,32 @@ _rtld(Elf_Addr *sp, func_ptr_type *exit_
      * descriptor using AT_EXECFD.
      */
     if (aux_info[AT_EXECFD] == NULL) {
-	bzero(&aux_execfd, sizeof(aux_execfd));
-	aux_execfd.a_type = AT_EXECFD;
-	aux_execfd.a_un.a_val = 7; /* TODO: stop hardcoding */
-	aux_info[AT_EXECFD] = &aux_execfd;
-	if (fstat(7, &sb) < 0) {
+	const char *ld_binary;
+	char *endp;
+	long ld_binary_fd;
+
+	ld_binary = getenv(LD_ "BINARY");
+	if (ld_binary == NULL) {
+	    _rtld_error("LD_BINARY unset; aborting");
+	    die();
+	}
+	ld_binary_fd = strtol(ld_binary, &endp, 10);
+	if (ld_binary_fd < 0 || ld_binary_fd > __INT_MAX || *endp != 0) {
+	    _rtld_error("LD_BINARY invalid");
+	    die();
+	}
+	if (fstat(ld_binary_fd, &sb) < 0) {
 	    __progname = "ld-elf-cap.so";
 	    _rtld_error("executable file descriptor unusable");
 	    die();
 	}
+	bzero(&aux_execfd, sizeof(aux_execfd));
+	aux_execfd.a_type = AT_EXECFD;
+	aux_execfd.a_un.a_val = ld_binary_fd;
+	aux_info[AT_EXECFD] = &aux_execfd;
     }
 #endif
 
-    /* XXXRW: Need to do something about program names in capability mode. */
-    __progname = obj_rtld.path; /* TODO: binary name */
-    argv0 = argv[0] != NULL ? argv[0] : "(null)";
-    environ = env;
-
     trust = !issetugid();
 
     ld_bind_now = getenv(LD_ "BIND_NOW");

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201002022051.o12KpZC6073825>