Date: Mon, 18 Feb 2019 12:49:07 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Charlie Li <ml+freebsd@vishwin.info> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, freebsd-toolchain@freebsd.org Subject: Re: svn commit: r341825 - in head: . contrib/compiler-rt contrib/compiler-rt/include/sanitizer contrib/compiler-rt/include/xray contrib/compiler-rt/lib/BlocksRuntime contrib/compiler-rt/lib/asan contri... Message-ID: <D472A7CA-760D-4733-8E72-2B0D0F2C0B65@FreeBSD.org> In-Reply-To: <e80319d3-1d52-6142-ef08-c58dfd27444e@vishwin.info> References: <201812111905.wBBJ5Yfu053488@repo.freebsd.org> <e80319d3-1d52-6142-ef08-c58dfd27444e@vishwin.info>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_95B52D4C-22C5-4154-A213-9440A1097A14
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=us-ascii
On 18 Feb 2019, at 12:40, Charlie Li via freebsd-toolchain =
<freebsd-toolchain@freebsd.org> wrote:
>=20
> On 11/12/2018 14:05, Dimitry Andric wrote:
>> head/contrib/libc++/include/type_traits
>>=20
> The change to the above named file breaks building any C++ code
> containing _Float16 with devel/llvm80-8.0.0.r2 (and probably later, =
but
> not 8.0.0.r1 or any earlier LLVM) on head (but not
> projects/clang800-import, obviously). Example error, from our own copy
> of LLVM libunwind:
>=20
> --- libunwind.o ---
> In file included from
> /usr/src/contrib/llvm/projects/libunwind/src/libunwind.cpp:18:
> In file included from
> /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/new:91:
> In file included from
> /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/exception:83:
> =
/usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/type_traits:740:56:
> error: _Float16 is not supported on this target
> template <> struct __libcpp_is_floating_point<_Float16> :
> public true_type {};
> ^
> 1 error generated.
> *** [libunwind.o] Error code 1
Hm, which target did you compile for? I have run multiple universe
builds, so I thought I had covered all possible targets. Or are you
building with gcc?
> Upstream LLVM has already reverted this: =
https://reviews.llvm.org/D53670
>=20
> world builds successfully after applying the upstream revert. Ports =
that
> use the clang portion of devel/llvm80 when set in DEFAULT_VERSIONS, ie
> gecko@, also build successfully.
Thanks, I'll take a look.
-Dimitry
--Apple-Mail=_95B52D4C-22C5-4154-A213-9440A1097A14
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.2
iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCXGqbswAKCRCwXqMKLiCW
o6ztAJ0TEzT8R6YqBoYDJmbOx28qZhyjbwCfVq88r0/J6AfoMQ0O+iQ3JuSqg1Y=
=t2C1
-----END PGP SIGNATURE-----
--Apple-Mail=_95B52D4C-22C5-4154-A213-9440A1097A14--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D472A7CA-760D-4733-8E72-2B0D0F2C0B65>