Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 7 Aug 2016 22:59:29 +0800
From:      Kevin Lo <kevlo@FreeBSD.org>
To:        Kubilay Kocak <koobs@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r419671 - in head/astro: . py-horoscopegenerator
Message-ID:  <20160807145929.GA11950@ns.kevlo.org>
In-Reply-To: <ab32ea72-b67b-bcfe-b30d-6a286f551ae3@FreeBSD.org>
References:  <201608050755.u757tYOi052449@repo.freebsd.org> <ab32ea72-b67b-bcfe-b30d-6a286f551ae3@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 05, 2016 at 06:09:45PM +1000, Kubilay Kocak wrote:
> 
> On 5/08/2016 5:55 PM, Kevin Lo wrote:
> > Author: kevlo
> > Date: Fri Aug  5 07:55:33 2016
> > New Revision: 419671
> > URL: https://svnweb.freebsd.org/changeset/ports/419671
> > 
> > Log:
> >   Import py-horoscopegenerator 0.1.8
> >   
> >   py-horoscopegenerator generates horoscopes using context-free grammar.
> > 
> > Added:
> >   head/astro/py-horoscopegenerator/
> >   head/astro/py-horoscopegenerator/Makefile   (contents, props changed)
> >   head/astro/py-horoscopegenerator/distinfo   (contents, props changed)
> >   head/astro/py-horoscopegenerator/pkg-descr   (contents, props changed)
> > Modified:
> >   head/astro/Makefile
> > 
> > Modified: head/astro/Makefile
> > ==============================================================================
> > --- head/astro/Makefile	Fri Aug  5 07:49:18 2016	(r419670)
> > +++ head/astro/Makefile	Fri Aug  5 07:55:33 2016	(r419671)
> > @@ -82,6 +82,7 @@
> >      SUBDIR += py-aipy
> >      SUBDIR += py-astLib
> >      SUBDIR += py-astropy
> > +    SUBDIR += py-horoscopegenerator
> >      SUBDIR += py-pyfits
> >      SUBDIR += py-pymetar
> >      SUBDIR += py-pywapi
> > 
> > Added: head/astro/py-horoscopegenerator/Makefile
> > ==============================================================================
> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ head/astro/py-horoscopegenerator/Makefile	Fri Aug  5 07:55:33 2016	(r419671)
> > @@ -0,0 +1,22 @@
> > +# $FreeBSD$
> > +
> > +PORTNAME=	horoscopegenerator
> > +PORTVERSION=	0.1.8
> > +CATEGORIES=	astro python
> > +MASTER_SITES=	CHEESESHOP
> > +DISTNAME=	${PORTNAME:S/h/H/:S/g/G/}-${PORTVERSION}
> > +PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
> > +
> > +MAINTAINER=	kevlo@FreeBSD.org
> > +COMMENT=	Generate horoscopes using context-free grammar
> > +
> > +LICENSE=	MIT
> > +
> > +NO_ARCH=	yes
> > +USES=		python
> 
> Limited to :2.7 [1]
> 
> [1]
> https://github.com/mouse-reeve/horoscope-generator/blob/master/setup.py#L32

It runs fine under Python 3.

> > +USE_PYTHON=	distutils autoplist
> > +
> > +RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}six>=0:devel/py-six \
> > +		${PYTHON_PKGNAMEPREFIX}nltk>0:textproc/py-nltk
> 
> Though it's listed in requirements.txt, I can't see six referenced in
> setup.py (*_requires) which is the canonical place to obtain real
> dependencies, as opposed to *.txt which are often used only for
> development, provisioning, testing, or otherwise
> non-'distribution/release' purposes.
> 
> Could be a bug (not listed in install_requires), or a non-dependency.
> 
> Either way worth it's worth testing (I cant see any import code for
> six), and then reporting (or creating PR) upstream if necessary.

Fixed in r419779.  This fix was confirmed by upstream, thanks.
> 
> > +
> > +.include <bsd.port.mk>
> > 
> > Added: head/astro/py-horoscopegenerator/distinfo
> > ==============================================================================
> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ head/astro/py-horoscopegenerator/distinfo	Fri Aug  5 07:55:33 2016	(r419671)
> > @@ -0,0 +1,3 @@
> > +TIMESTAMP = 1470381700
> > +SHA256 (HoroscopeGenerator-0.1.8.tar.gz) = 96b9f577f7024d131bd3a080a2e177494fa41a36d803bd5f0ec21133bad90073
> > +SIZE (HoroscopeGenerator-0.1.8.tar.gz) = 6443
> > 
> > Added: head/astro/py-horoscopegenerator/pkg-descr
> > ==============================================================================
> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ head/astro/py-horoscopegenerator/pkg-descr	Fri Aug  5 07:55:33 2016	(r419671)
> > @@ -0,0 +1,4 @@
> > +The HoroscopeGenerator produces horoscopes on demand using context-free
> > +grammar. 
> > +
> > +WWW: https://github.com/mouse-reeve/horoscope-generator
> > 
> 
> 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160807145929.GA11950>