Date: Wed, 21 Mar 2018 10:12:05 -0500 From: Kyle Evans <kevans@freebsd.org> To: Devin Teske <dteske@freebsd.org> Cc: Kyle Evans <kevans@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331259 - head/stand/lua Message-ID: <CACNAnaFY31TTcQTaOmtVuWQR0LkQuMfQnA619EDnU=zG%2BP2vLQ@mail.gmail.com> In-Reply-To: <401EA542-5E2B-4342-B098-7C8D78FAD721@freebsd.org> References: <201803202026.w2KKQOP2036471@repo.freebsd.org> <401EA542-5E2B-4342-B098-7C8D78FAD721@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 20, 2018 at 6:04 PM, Devin Teske <dteske@freebsd.org> wrote: > > Minor nit ... > > While resetf is unlikely to be mistaken for anything other than "reset foreground", ... > > "resetb" could easily be mistaken for "reset bold". > > I would like to suggest, in tradition, that resetf/resetb be renamed to resetfg/resetbg > > You know... should you want to add a "resetb" later that actually resets bold (e.g., if you have to use CSI 22m in more than one place). > -- > Devin This set of functions has been renamed in r331304. The choice of 'f' and 'b' always kind of bothered me, but not enough to actually fix it until someone else complained about it. =)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaFY31TTcQTaOmtVuWQR0LkQuMfQnA619EDnU=zG%2BP2vLQ>