Date: Wed, 4 Apr 2007 17:33:09 -0400 From: Jason Harris <jharris@widomaker.com> To: Rong-En Fan <rafan@FreeBSD.org>, Gabor Kovesdan <gabor@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Jason Harris <jharris@widomaker.com>, cvs-all@FreeBSD.org, Mark Linimon <linimon@FreeBSD.org>, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/ports-mgmt/portmk/Mk bsd.port.mk Message-ID: <20070404213309.GA18092@wilma.widomaker.com> In-Reply-To: <4613FB27.9030107@FreeBSD.org> <20070404192011.GJ55471@svm.csie.ntu.edu.tw> References: <200704041702.l34H222T004152__31953.9864351556$1175706304$gmane$org@repoman.freebsd.org> <20070404191038.GA15948@wilma.widomaker.com> <4613FB27.9030107@FreeBSD.org> <200704041702.l34H222T004152__31953.9864351556$1175706304$gmane$org@repoman.freebsd.org> <20070404191038.GA15948@wilma.widomaker.com> <20070404192011.GJ55471@svm.csie.ntu.edu.tw>
next in thread | previous in thread | raw e-mail | index | archive | help
--9amGYk9869ThD9tj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 05, 2007 at 03:20:11AM +0800, Rong-En Fan wrote: > On Wed, Apr 04, 2007 at 03:10:38PM -0400, Jason Harris wrote: > > Rather than invoke dozens of needless processes, I simply pass > > MD5_FILE=3D/dev/null to the "make fetch" in the makesum target. > > (Note that this also removes the need to set NO_CHECKSUM=3Dyes and > > DISABLE_SIZE=3Dyes in the same target, further simplfying things.) >=20 > Note that it does not solve 'make fetch' when there is no MD5_FILE > (this is another regression with latest bsd.port.mk). DISTINFO_DATA > still needs to check existence of MD5_FILE. Remember, this is the "make makesum" step we're all (supposed to be) talking about. That is, MD5_FILE is truncated to 0 bytes and is added to in several steps. The regression, AFAICT, is that awk is run when MD5_FILE doesn't exist (rather than empty/truncated), returns non-zero, and kills the make. On Wed, Apr 04, 2007 at 09:23:19PM +0200, Gabor Kovesdan wrote: > >Rather than invoke dozens of needless processes, I simply pass > >MD5_FILE=3D/dev/null to the "make fetch" in the makesum target. > even officially supported. You claimed that I don't respect the users'=20 > need for higher security. Saying that, how can you go such an insecure=20 > way now, then? > (I don't want to throw another flamebait, I just don't see the whole=20 > situation.) Indeed. To reiterate, this is the "make makesum" step, where MD5_FILE is [re]created, not consulted. --=20 Jason Harris | NIC: JH329, PGP: This _is_ PGP-signed, isn't it? jharris@widomaker.com _|_ web: http://keyserver.kjsl.com/~jharris/ Got photons? (TM), (C) 2004 --9amGYk9869ThD9tj Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iJ0EARECAF0FAkYUGZRWGGh0dHA6Ly9rZXlzZXJ2ZXIua2pzbC5jb206MTEzNzEv cGtzL2xvb2t1cD9vcD1nZXQmc2VhcmNoPTB4RDM5REEwRTMmd2VoYXZleW91bm93 PXRydWUACgkQSypIl9OdoOMaBQCgxZimemOYklHF1vEqCKsujBsmWCsAn1bCn2Ix Z5BBJThwJz7WIMG1Cz8j =YldZ -----END PGP SIGNATURE----- --9amGYk9869ThD9tj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070404213309.GA18092>